Don't pass in the filter argument to tar.extractall on old Python versions #3568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
changed the title
…sions Signed-off-by: Bernát Gábor <[email protected]>
ssbarnea
reviewed
Jul 26, 2025
| @@ -25,9 +25,9 @@ repos: | |||
| - repo: https://github.com/astral-sh/ruff-pre-commit | |||
| rev: "v0.12.4" | |||
| hooks: | |||
| - id: ruff-format | |||
| - id: ruff | |||
| - id: ruff-check | |||
There was a problem hiding this comment.
@gaborbernat Why have you moved the format after check on ruff? My impression was that it was far better to do the format first and the check with fix after. Reason for this being that reformatting is likely to also include fixes for stuff that check might only complain about, so more noise.
Am I wrong? ChatGPT seems to agree, not that I would trust it so much anyway.
There was a problem hiding this comment.
https://github.com/astral-sh/ruff-pre-commit it's what the official doc recommended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3565