Skip to content

Allow ConfigSet.add_config to receive parameterized generics for of_type. #3288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2024
Merged

Allow ConfigSet.add_config to receive parameterized generics for of_type. #3288

merged 2 commits into from
May 31, 2024

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 29, 2024 •
edited
Loading

Allow ConfigSet.add_config to receive parameterized generics for of_type.

Fixes: #3287

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@ssbarnea ssbarnea added the bug:minor does not affect many people or has no big impact label May 29, 2024
@ssbarnea ssbarnea changed the title Allow use of list[str] inside plugins Allow ConfigSet.add_config to receive parameterized generics for of_type. May 29, 2024
@ssbarnea ssbarnea force-pushed the fix/type branch 2 times, most recently from f20e12f to c60aab8 Compare May 29, 2024 12:40
@ssbarnea ssbarnea marked this pull request as ready for review May 29, 2024 12:46
@ssbarnea ssbarnea requested a review from gaborbernat as a code owner May 29, 2024 12:46
@ssbarnea ssbarnea requested a review from a team May 29, 2024 13:10
gaborbernat
gaborbernat requested changes May 29, 2024
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot accept anything without test...

@cidrblock cidrblock mentioned this pull request May 29, 2024
Merged
@ssbarnea ssbarnea marked this pull request as draft May 31, 2024 16:06
@ssbarnea
Copy link
Member Author

I cannot accept anything without test...

But of course! Note that I was not able to use pytest skip marks to avoid py38 because interpreter failed to load the test file itself. Still, using an if before the test definition worked fine.

@ssbarnea ssbarnea marked this pull request as ready for review May 31, 2024 16:38
@ssbarnea ssbarnea requested a review from gaborbernat May 31, 2024 16:38
@gaborbernat gaborbernat merged commit 7317225 into main May 31, 2024
@gaborbernat gaborbernat deleted the fix/type branch May 31, 2024 23:56
@cidrblock cidrblock mentioned this pull request Jun 7, 2024
Merged
seyidaniels pushed a commit to seyidaniels/tox that referenced this pull request Jun 10, 2024
@ssbarnea @pre-commit-ci @seyidaniels
Allow ConfigSet.add_config to receive parameterized generics for `o…
544f711 
…f_type`. (tox-dev#3288)

* Allow use of list[str] inside plugins

Fixes: tox-dev#3287

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
naa0yama referenced this pull request in naa0yama/ffvqe Jul 31, 2024
@naa0yama
chore(deps): update dependency tox to v4.15.1 (#48)
ef6c518 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox)
([changelog](https://tox.wiki/en/latest/changelog.html)) | `4.15.0` ->
`4.15.1` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/tox/4.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/tox/4.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/tox/4.15.0/4.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/tox/4.15.0/4.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>tox-dev/tox (tox)</summary>

### [`v4.15.1`](https://togithub.com/tox-dev/tox/releases/tag/4.15.1)

[Compare
Source](https://togithub.com/tox-dev/tox/compare/4.15.0...4.15.1)

<!-- Release notes generated using configuration in .github/release.yml
at 4.15.1 -->

#### What's Changed

- fix skip with package = wheel by
[@&#8203;MarcinKonowalczyk](https://togithub.com/MarcinKonowalczyk) in
[https://github.com/tox-dev/tox/pull/3269](https://togithub.com/tox-dev/tox/pull/3269)
- Fixed typo in user guide. by
[@&#8203;carltongibson](https://togithub.com/carltongibson) in
[https://github.com/tox-dev/tox/pull/3277](https://togithub.com/tox-dev/tox/pull/3277)
- Fix broad build privileges @&#8203; GHA release workflow by
[@&#8203;webknjaz](https://togithub.com/webknjaz) in
[https://github.com/tox-dev/tox/pull/3281](https://togithub.com/tox-dev/tox/pull/3281)
- Allow `ConfigSet.add_config` to receive parameterized generics for
`of_type`. by [@&#8203;ssbarnea](https://togithub.com/ssbarnea) in
[https://github.com/tox-dev/tox/pull/3288](https://togithub.com/tox-dev/tox/pull/3288)
- Fix section substitution with setenv by
[@&#8203;JJLLWW](https://togithub.com/JJLLWW) in
[https://github.com/tox-dev/tox/pull/3289](https://togithub.com/tox-dev/tox/pull/3289)

#### New Contributors

- [@&#8203;MarcinKonowalczyk](https://togithub.com/MarcinKonowalczyk)
made their first contribution in
[https://github.com/tox-dev/tox/pull/3269](https://togithub.com/tox-dev/tox/pull/3269)
- [@&#8203;carltongibson](https://togithub.com/carltongibson) made their
first contribution in
[https://github.com/tox-dev/tox/pull/3277](https://togithub.com/tox-dev/tox/pull/3277)
- [@&#8203;JJLLWW](https://togithub.com/JJLLWW) made their first
contribution in
[https://github.com/tox-dev/tox/pull/3289](https://togithub.com/tox-dev/tox/pull/3289)

**Full Changelog**:
tox-dev/tox@4.15.0...4.15.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/naa0yama/FFmpeg-video-quality-evaluations).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkYXRhc291cmNlOnB5cGkiLCJkZXBUeXBlOmRldiIsIm1hbmFnZXI6cG9ldHJ5IiwicmVub3ZhdGUiLCJ1cGRhdGUtcGF0Y2giLCJ2ZXJzaW9uaW5nOnBvZXRyeSJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided bug:minor does not affect many people or has no big impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: isinstance() argument 2 cannot be a parameterized generic
2 participants
@ssbarnea @gaborbernat