Skip to content

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Nov 26, 2022

Fixes: #2414

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@ssbarnea ssbarnea added the bug:minor does not affect many people or has no big impact label Nov 26, 2022
@ssbarnea ssbarnea force-pushed the v4/cmd-color branch 2 times, most recently from 8eb4416 to 145909b Compare November 26, 2022 17:09
@ssbarnea ssbarnea marked this pull request as ready for review November 26, 2022 17:15
@ssbarnea ssbarnea added this to the 4.0 milestone Nov 26, 2022
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all sc200 noqa. The extra words need to be in the root dictionary file not ignored.

@ssbarnea
Copy link
Member Author

ssbarnea commented Nov 26, 2022

Remove all sc200 noqa. The extra words need to be in the root dictionary file not ignored.

Very uninspired name for a dictionary file. I did search for a file names dictionary in repo and failed to find one, so I imagined there is none. Now, the whitelist is another issue by itself and I somehow I have the impression that you do remember the joys of allowlist_externals, main/master branch,... :p

@gaborbernat
Copy link
Member

Very uninspired name for a dictionary file. I did search for a file names dictionary in repo and failed to find one, so I imagined there is none. Now, the whitelist is another issue by itself and I somehow I have the impression that you do remember the joys of allowlist_externals, main/master branch,... :p

Until upstream adds support for the different name we'll have to roll with this.

@ssbarnea ssbarnea force-pushed the v4/cmd-color branch 2 times, most recently from 4f5d9b7 to 428e921 Compare November 26, 2022 18:42
Signed-off-by: Bernát Gábor <[email protected]>
Signed-off-by: Bernát Gábor <[email protected]>
@ssbarnea ssbarnea changed the title Avoid impossible impossible minversion requirement Avoid impossible minversion requirement Nov 26, 2022
@gaborbernat gaborbernat merged commit 70601f9 into tox-dev:rewrite Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided bug:minor does not affect many people or has no big impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants