Skip to content

Avoid importing pipes on Python 3.3+ #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

Avoid importing pipes on Python 3.3+ #2418

merged 1 commit into from
May 12, 2022

Conversation

adamchainz
Copy link
Contributor

Fixes #2417.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example: 
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

adamchainz
adamchainz commented May 11, 2022
View reviewed changes
@adamchainz adamchainz force-pushed the issue_2417_pipes_warnings branch from 60d9fe0 to 3a7a7cf Compare May 11, 2022 14:41
asottile
asottile approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gaborbernat
gaborbernat approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile
Copy link
Contributor

kinda funny coincidence, my video today is exactly about preferring the if-statement approach -- https://youtu.be/B94tqnXeFnQ

@jugmac00 jugmac00 merged commit f840390 into tox-dev:master May 12, 2022
This was referenced Aug 12, 2023
Open
Open
Open
Open
Open
Open
Open
Leo3418 pushed a commit to yxlvcs-rit/csci-352-2241 that referenced this pull request Oct 28, 2024
gradelib.py: Use 'shlex' instead of 'pipes' for Python 3.13
7b4ad1c 
The 'pipes' Python module has been deprecated for a while and been
removed in Python 3.13 [1].  A drop-in replacement for 'pipes.quote()'
is 'shlex.quote()' [2][3].

[1]: https://www.python.org/downloads/release/python-3130/
[2]: tox-dev/tox#2418
[3]: llvm/llvm-project#93376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@obestwalter obestwalter Awaiting requested review from obestwalter

+1 more reviewer

@asottile asottile asottile approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.11 deprecation warning: 'pipes' is deprecated and slated for removal in Python 3.13
4 participants
@adamchainz @asottile @gaborbernat @jugmac00