update hidden nodes peer to use the subnet of the public node #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the public node not the hidden node subnet Co-authored-by: AhmedHanafy725 <[email protected]>
Omarabdul3ziz
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
AbdelrahmanElawady,
xmonader,
sameh-farouk and
Eslam-Nawara
as code owners
rawdaGastan
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while investigating a problem in network deployment, we found that the peer in hidden nodes uses its own subnet instead of the chosen publicNode subnet.
eventually it turns out it is not the problem we faced, and since the allowed list in this peer have
*/16subnet range which include both (hidden node/public node) ips it will work fine.but it is more clear to use the publicNode subnet to remove confusion in future