Skip to content

Conversation

thomasbuilds
Copy link

@thomasbuilds thomasbuilds commented Sep 9, 2025

This PR improves @web3-onboard/solid by ensuring SSR compatibility and optimizing performance.
Key changes:

  • SSR Compatibility: Guarded client-only APIs (localStorage, Web3Onboard) with isServer
  • Performance: Used createMemo with custom equals, batch for grouped updates, and onCleanup for subscription cleanup.
  • Error Handling: Added try-catch for localStorage and Web3Onboard operations.

Copy link

coderabbitai bot commented Sep 9, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

socket-security bot commented Sep 9, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedtsup@​7.2.0 ⏵ 8.5.098 +1100 +594 +184 +1100
Updatedsolid-devtools@​0.27.7 ⏵ 0.34.392 +1100100 +184100
Addedsolid-js@​1.9.910010010092100

View full report

@thomasbuilds thomasbuilds changed the title Update @web3-onboard/solidjs Update @web3-onboard/solid Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant