Skip to content

Conversation

AkshayGadhaveRH
Copy link
Contributor

Adding a module for installation overview with high level steps and links to each step.

JIRA: https://issues.redhat.com/browse/SAT-30834

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

Review checklists

Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):

  • The PR documents a recommended, user-friendly path.
  • The PR removes steps that have been made unnecessary or obsolete.
  • Any steps introduced or updated in the PR have been tested to confirm that they lead to the documented end result.

Style review (by a Technical Writer who did not author the PR):

  • The PR conforms with the team's style guidelines.
  • The PR introduces documentation that describes a user story rather than a product feature.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Aug 7, 2025
@AkshayGadhaveRH AkshayGadhaveRH removed Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Not yet reviewed Needs testing Requires functional testing labels Aug 7, 2025
Copy link

github-actions bot commented Aug 7, 2025

@AkshayGadhaveRH
Copy link
Contributor Author

Working on fixing the build issues. Not ready for review yet.

@AkshayGadhaveRH AkshayGadhaveRH force-pushed the add_installation_overview branch from 8fb89ed to c05e6d7 Compare August 12, 2025 05:41
@AkshayGadhaveRH AkshayGadhaveRH marked this pull request as ready for review August 12, 2025 05:49
@AkshayGadhaveRH AkshayGadhaveRH added Needs style review Requires a review from docs style/grammar perspective Not yet reviewed labels Aug 12, 2025
@AkshayGadhaveRH AkshayGadhaveRH marked this pull request as draft August 20, 2025 05:22
Akshay Gadhave added 3 commits September 23, 2025 12:21
Adding a module for installation overview with high level steps and links to each step.

JIRA: https://issues.redhat.com/browse/SAT-30834
@AkshayGadhaveRH AkshayGadhaveRH force-pushed the add_installation_overview branch from c05e6d7 to 6783e24 Compare September 23, 2025 06:52
@AkshayGadhaveRH AkshayGadhaveRH marked this pull request as ready for review September 23, 2025 08:08
@AkshayGadhaveRH AkshayGadhaveRH added the Needs tech review Requires a review from the technical perspective label Sep 23, 2025
Copy link
Member

@aneta-petrova aneta-petrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akshay! This works better than a list with links.

Comment on lines +11 to +12
.Planning
Make sure that your infrastructure meets the prerequisites for installation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discrete headings (like .Planning) will eventually be reported as issues by asciidoctor-dita-vale so it would be good not to add new ones. Thinking about how to make this section flow naturally, one option might be this:

Suggested change
.Planning
Make sure that your infrastructure meets the prerequisites for installation:
During planning, you will make sure that your infrastructure meets the prerequisites for installation.
This includes the following actions:

This is just a quick suggestion, feel free to tweak it :) The changes I'm making are:

  • Replacing discrete heading with a descriptive "During planning, (...)". This adds more words but avoids the need for the discrete heading.
  • This includes the following actions: helps prevent potential future situations when a new "action" might be added to planning but noone updates this list. (I'm not sure about the word "action" to be honest.)

What do you think? If this sounds good, can you look into updating the other discrete headings in a similar way? Whatever wording you choose, they should all be consistent.

Make sure that your infrastructure meets the prerequisites for installation:

* Ensure your hardware and software meet the minimum requirements for CPU, RAM, and storage space.
* Plan your network setup, including DNS resolution and port/firewall configurations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Plan your network setup, including DNS resolution and port/firewall configurations.
* Plan your network setup, including DNS resolution and firewall configurations.


* Ensure your hardware and software meet the minimum requirements for CPU, RAM, and storage space.
* Plan your network setup, including DNS resolution and port/firewall configurations.
* For large deployments (e.g., more than 5,000 hosts), select a predefined performance profile to optimize your system.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* For large deployments (e.g., more than 5,000 hosts), select a predefined performance profile to optimize your system.
* For large deployments of more than 5,000 hosts, consider whether to use a predefined tuning profile to optimize {Project} performance.

The changes I'm proposing are:

  • Drop "e.g."
  • Phrase this action as optional ("consider") rather than required ("select")
  • Clarify that it's {Project} that's being optimized, not really "the system"

@aneta-petrova
Copy link
Member

Speaking in more general terms, this request came from Red Hat's downstream. In upstream, I've been mostly hearing about concerns that the installation guide is very long, which doesn't work well for upstream users. Therefore, I'm wondering: Should we only include the new overview for Satellite to address the downstream need, while excluding it from upstream to better accommodate the upstream users' needs?

@maximiliankolb
Copy link
Contributor

Should we only include the new overview for Satellite to address the downstream need, while excluding it from upstream to better accommodate the upstream users' needs?

IMO there's value in this overview, so I am OK with adding it for all flavours.


* Install the {Project} package and all its dependencies.
* Use the `{foreman-installer}` command to perform the initial server setup.
* Import your subscription manifest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're rendering the overview for all builds, this needs to be hidden for foreman-{el,deb}

.Server preparation
Configure the operating system and the repositoties for installating {Project}:

* Install {EL} 9 on a freshly installed system.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're rendering the overview for all builds, this needs to be changed for foreman-deb to Debian 12 or Ubuntu 22.04 or something.

[id="overview-of-the-installation-process"]
= Overview of the installation process

The {Project} installation process can be broken down into three main phases:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The {Project} installation process can be broken down into three main phases:
The {Project} installation process consists of the following main phases:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants