Rewrite html plugin #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
commented
Jan 29, 2023
Comment on lines
+1
to
+19
| Document(root) | ||
| html(element) | ||
| head(element) | ||
| title(element) | ||
| Str(text) | ||
| Str(text) | ||
| body(element) | ||
| Str(text) | ||
| Paragraph(element) | ||
| span(element) | ||
| Str(text) | ||
| Str(text) | ||
| Paragraph(element) | ||
| span(element) | ||
| span(element) | ||
| Str(text) | ||
| span(element) | ||
| Str(text) | ||
| Str(text) |
There was a problem hiding this comment.
<html>
<head><title>テスト</title></head>
<body>
<p><span>こんにちは、世界。</span></p>
<p><span><span>こんにちは、</span><span>世界。</span></span></p>
</body>
</html>to be this.
There was a problem hiding this comment.
textlint-util-to-string can get "こんにちは、世界。"
azu
added
Type: Breaking Change
azu
commented
Jan 29, 2023
| "description": "", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "textlint test/ -f pretty-error || exit 0" |
Comment on lines
+176
to
+193
| if (txtNode.type === "Link") { | ||
| if (txtNode.properties.href !== undefined) txtNode.url = txtNode.properties.href; | ||
| if (txtNode.properties.title !== undefined) txtNode.title = txtNode.properties.title; | ||
| } else if (txtNode.type === "Image") { | ||
| if (txtNode.properties.alt !== undefined) txtNode.alt = txtNode.properties.alt; | ||
| if (txtNode.properties.title !== undefined) txtNode.title = txtNode.properties.title; | ||
| if (txtNode.properties.src !== undefined) txtNode.url = txtNode.properties.src; | ||
| } else if (txtNode.type === "Header") { | ||
| const depth = Number(txtNode.tagName.slice(1)) as TxtHeaderNode["depth"]; | ||
| if (depth > 0 && depth < 7) txtNode.depth = depth; | ||
| } else if (txtNode.type === "List") { | ||
| if (txtNode.tagName === "ul") { | ||
| txtNode.ordered = false; | ||
| } else if (txtNode.tagName === "ol") { | ||
| txtNode.ordered = true; | ||
| } | ||
| } | ||
| } |
Comment on lines
+61
to
+66
| } else { | ||
| // other case, return original tagName | ||
| return node.tagName; | ||
| } | ||
| } else if (node.type === "doctype") { | ||
| return "doctype"; |
There was a problem hiding this comment.
This will fix #19
html to be html
Previously, html to be Html. This cause textlint-ja/textlint-rule-no-synonyms#4
Comment on lines
+1
to
+13
| Document(root) | ||
| doctype(doctype) | ||
| html(element) | ||
| head(element) | ||
| title(element) | ||
| Str(text) | ||
| Str(text) | ||
| body(element) | ||
| Paragraph(element) | ||
| Str(text) | ||
| Str(text) | ||
| table(element) | ||
| Str(text) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite ALL!!!
Breaking Changes
Features
<h1>...<h6>'slevels<ul>and<ol><img />'saltandtitle<a>'stitleBug Fixes
fix #19
fix textlint-ja/textlint-rule-no-synonyms#4
fix #2
close #15 - It looks like rule implementation issue https://github.com/KeitaMoromizato/textlint-rule-max-appearence-count-of-words/blob/master/src/max-appearence-count-of-words.js
Testings
📝 Welcome to contribute! We looking for new maintainer!