Add Opensearch module #1072
Merged
Add Opensearch module #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Fixes #1071 |
cristianrgreco
added
enhancement
|
LGTM! Just missing an entry in dependabot.yml https://github.com/testcontainers/testcontainers-node/blob/3f3eed17742d4d48118959542571b3480811d138/.github/dependabot.yml |
|
Thanks @JohanObrink |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I didn't read the CONTRIB guidelines before starting work on the PR but I hope you will accept it without a prior Issue.
I looked at how the Testcontainer for Elasticsearch was built and tried to maintain the same style. I also basically copied the tests almost verbatim.
One thing added to the container that differs from the Elasticsearch implementation is a validation of the password which, if set, has to adhere to the requirements of the OpenSearch demo container. I added a check for this in TS to make it fail faster and with a more readable error message.
Otherwise, the container implementation follows the settings of the Dotnet OpenSearch container.
Two tests fail - for Kafka and BigQuery. It did not seem right to touch those tests in this PR.