Skip to content

Conversation

sassdavid
Copy link
Contributor

@sassdavid sassdavid commented May 18, 2025

Description

For Managed Streaming for Kafka credentials, both client_certificate_tls_auth and sasl_scram_512_auth are optional. The current implementation does not allow using only one of them independently.

Motivation and Context

After this change, the following code will be valid for source_parameters:

source_parameters = {
  managed_streaming_kafka_parameters = {
    topic_name = var.input_kafka_topic
    batch_size = 10
    credentials = {
      sasl_scram_512_auth = var.msk_secret_arn
    }
  }
}

Currently, only the following form is accepted:

source_parameters = {
  managed_streaming_kafka_parameters = {
    topic_name = var.input_kafka_topic
    batch_size = 10
    credentials = {
      sasl_scram_512_auth         = var.msk_secret_arn
      client_certificate_tls_auth = valid_arn
    }
  }
}

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@sassdavid sassdavid changed the title fix: usage of managed streaming kafka credentials fix: Usage of managed streaming kafka credentials May 18, 2025
@sassdavid
Copy link
Contributor Author

Hi @antonbabenko ,
Can you help me review the PR? Maybe point in the right direction if something should be done differently.

@antonbabenko antonbabenko merged commit 11f446f into terraform-aws-modules:master May 19, 2025
15 checks passed
antonbabenko pushed a commit that referenced this pull request May 19, 2025
## [3.17.1](v3.17.0...v3.17.1) (2025-05-19)

### Bug Fixes

* Usage of managed streaming kafka credentials ([#162](#162)) ([11f446f](11f446f))
@antonbabenko
Copy link
Member

This PR is included in version 3.17.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants