Skip to content

feat: Add lifecycle_hook.hook_details #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

feat: Add lifecycle_hook.hook_details #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbe360c
add lifecycle_hook_details
magreenbaum Sep 18, 2025
63af405
update root module variable definition
magreenbaum Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions examples/complete/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ Note that this example may create resources which will incur monetary charges on
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.5.7 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.11 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.14 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.11 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.14 |

## Modules

Expand Down
2 changes: 1 addition & 1 deletion examples/complete/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}
2 changes: 1 addition & 1 deletion examples/container-definition/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Note that this example may create resources which will incur monetary charges on
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.5.7 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.11 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.14 |
| <a name="requirement_null"></a> [null](#requirement\_null) | >= 3.2 |

## Providers
Expand Down
2 changes: 1 addition & 1 deletion examples/container-definition/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
null = {
source = "hashicorp/null"
Expand Down
4 changes: 2 additions & 2 deletions examples/ec2-autoscaling/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ Note that this example may create resources which will incur monetary charges on
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.5.7 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.11 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.14 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.11 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.14 |

## Modules

Expand Down
2 changes: 1 addition & 1 deletion examples/ec2-autoscaling/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}
4 changes: 2 additions & 2 deletions examples/fargate/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ Note that this example may create resources which will incur monetary charges on
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.5.7 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.11 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.14 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.11 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.14 |

## Modules

Expand Down
1 change: 1 addition & 0 deletions examples/fargate/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ module "ecs_service" {
# hook_target_arn = aws_lambda_function.hook_success.arn
# role_arn = aws_iam_role.global.arn
# lifecycle_stages = ["POST_SCALE_UP", "POST_TEST_TRAFFIC_SHIFT"]
# hook_details = jsonencode("test")
# }
# failure = {
# hook_target_arn = aws_lambda_function.hook_failure.arn
Expand Down
2 changes: 1 addition & 1 deletion examples/fargate/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}
4 changes: 2 additions & 2 deletions modules/cluster/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,13 @@ module "ecs_cluster" {
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.5.7 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.11 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.14 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.11 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.14 |

## Modules

Expand Down
2 changes: 1 addition & 1 deletion modules/cluster/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}
4 changes: 2 additions & 2 deletions modules/container-definition/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,13 @@ module "example_ecs_container_definition" {
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.5.7 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.11 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.14 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.11 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.14 |

## Modules

Expand Down
2 changes: 1 addition & 1 deletion modules/container-definition/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}
6 changes: 3 additions & 3 deletions modules/service/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,13 @@ module "ecs_service" {
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.5.7 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.11 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 6.14 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.11 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 6.14 |

## Modules

Expand Down Expand Up @@ -250,7 +250,7 @@ module "ecs_service" {
| <a name="input_create_task_exec_policy"></a> [create\_task\_exec\_policy](#input\_create\_task\_exec\_policy) | Determines whether the ECS task definition IAM policy should be created. This includes permissions included in AmazonECSTaskExecutionRolePolicy as well as access to secrets and SSM parameters | `bool` | `true` | no |
| <a name="input_create_tasks_iam_role"></a> [create\_tasks\_iam\_role](#input\_create\_tasks\_iam\_role) | Determines whether the ECS tasks IAM role should be created | `bool` | `true` | no |
| <a name="input_deployment_circuit_breaker"></a> [deployment\_circuit\_breaker](#input\_deployment\_circuit\_breaker) | Configuration block for deployment circuit breaker | <pre>object({<br/> enable = bool<br/> rollback = bool<br/> })</pre> | `null` | no |
| <a name="input_deployment_configuration"></a> [deployment\_configuration](#input\_deployment\_configuration) | Configuration block for deployment settings | <pre>object({<br/> strategy = optional(string)<br/> bake_time_in_minutes = optional(string)<br/> lifecycle_hook = optional(map(object({<br/> hook_target_arn = string<br/> role_arn = string<br/> lifecycle_stages = list(string)<br/> })))<br/> })</pre> | `null` | no |
| <a name="input_deployment_configuration"></a> [deployment\_configuration](#input\_deployment\_configuration) | Configuration block for deployment settings | <pre>object({<br/> strategy = optional(string)<br/> bake_time_in_minutes = optional(string)<br/> lifecycle_hook = optional(map(object({<br/> hook_target_arn = string<br/> role_arn = string<br/> lifecycle_stages = list(string)<br/> hook_details = optional(string)<br/> })))<br/> })</pre> | `null` | no |
| <a name="input_deployment_controller"></a> [deployment\_controller](#input\_deployment\_controller) | Configuration block for deployment controller configuration | <pre>object({<br/> type = optional(string)<br/> })</pre> | `null` | no |
| <a name="input_deployment_maximum_percent"></a> [deployment\_maximum\_percent](#input\_deployment\_maximum\_percent) | Upper limit (as a percentage of the service's `desired_count`) of the number of running tasks that can be running in a service during a deployment | `number` | `200` | no |
| <a name="input_deployment_minimum_healthy_percent"></a> [deployment\_minimum\_healthy\_percent](#input\_deployment\_minimum\_healthy\_percent) | Lower limit (as a percentage of the service's `desired_count`) of the number of running tasks that must remain running and healthy in a service during a deployment | `number` | `66` | no |
Expand Down
2 changes: 2 additions & 0 deletions modules/service/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ resource "aws_ecs_service" "this" {
hook_target_arn = lifecycle_hook.value.hook_target_arn
role_arn = lifecycle_hook.value.role_arn
lifecycle_stages = lifecycle_hook.value.lifecycle_stages
hook_details = lifecycle_hook.value.hook_details
}
}
}
Expand Down Expand Up @@ -411,6 +412,7 @@ resource "aws_ecs_service" "ignore_task_definition" {
hook_target_arn = lifecycle_hook.value.hook_target_arn
role_arn = lifecycle_hook.value.role_arn
lifecycle_stages = lifecycle_hook.value.lifecycle_stages
hook_details = lifecycle_hook.value.hook_details
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the root module variable definition as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 whoops, updated. Thanks!

}
}
}
Expand Down
1 change: 1 addition & 0 deletions modules/service/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ variable "deployment_configuration" {
hook_target_arn = string
role_arn = string
lifecycle_stages = list(string)
hook_details = optional(string)
})))
})
default = null
Expand Down
2 changes: 1 addition & 1 deletion modules/service/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}
1 change: 1 addition & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ variable "services" {
hook_target_arn = string
role_arn = string
lifecycle_stages = list(string)
hook_details = optional(string)
})))
}))
deployment_controller = optional(object({
Expand Down
2 changes: 1 addition & 1 deletion versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}
2 changes: 1 addition & 1 deletion wrappers/cluster/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}
2 changes: 1 addition & 1 deletion wrappers/container-definition/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}
2 changes: 1 addition & 1 deletion wrappers/service/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}
2 changes: 1 addition & 1 deletion wrappers/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 6.11"
version = ">= 6.14"
}
}
}