Skip to content

Conversation

magreenbaum
Copy link
Member

Description

Adds lifecycle_hook.hook_details support.

Motivation and Context

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@@ -411,6 +412,7 @@ resource "aws_ecs_service" "ignore_task_definition" {
hook_target_arn = lifecycle_hook.value.hook_target_arn
role_arn = lifecycle_hook.value.role_arn
lifecycle_stages = lifecycle_hook.value.lifecycle_stages
hook_details = lifecycle_hook.value.hook_details
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the root module variable definition as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 whoops, updated. Thanks!

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs bryantbiggs merged commit 73b7104 into terraform-aws-modules:master Sep 18, 2025
12 checks passed
antonbabenko pushed a commit that referenced this pull request Sep 18, 2025
## [6.4.0](v6.3.0...v6.4.0) (2025-09-18)

### Features

* Add `lifecycle_hook.hook_details` ([#354](#354)) ([73b7104](73b7104))
@antonbabenko
Copy link
Member

This PR is included in version 6.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants