This repository was archived by the owner on Sep 27, 2024. It is now read-only.
Fix failing tests #245
Merged
Fix failing tests #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Previously, some tests were failing due to
JSONDecodeErrors sincecats_vs_dogs.jsonwas corrupted orModuleNotFoundErrors sincetensorflow-datasetswasn't installed. This PR fixes those tests.How did you test this change?
I ran all tests with
find . -name '*_test.py' | xargs -I {} python {}. After I made my changes, I installedtensorflow-datasetsusingpip install '.[test]'and reran the tests.How did you document this change?
TODO as part of #239
Before submitting
Before submitting a pull request, please be sure to do the following: