Skip to content

Conversation

okxiaoliang4
Copy link
Contributor

TanStack Start build to cloudflare-module, debug value type is boolean.
reference: https://developers.cloudflare.com/workers/framework-guides/web-apps/tanstack/

Summary

image

Test plan

TanStack Start build to `cloudflare-module`, `debug` value type is boolean.
@okxiaoliang4 okxiaoliang4 requested a review from a team as a code owner July 8, 2025 18:12
@thecrypticace
Copy link
Contributor

This seems like a bug in cloudflare-module? afaik process.env.* should always be strings. The types for Node seem to indicate this:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/f8a95123ad42b8d1c06927c1bfac4fb9a13bf345/types/node/v22/process.d.ts#L346-L351

@thecrypticace thecrypticace self-assigned this Jul 8, 2025
@thecrypticace thecrypticace changed the title fix: robustness Update fix: allow process.env.DEBUG to be a boolean in @tailwindcss/node Jul 8, 2025
@thecrypticace
Copy link
Contributor

Discussed this a bit internally and while it feels like a bug that process.env.* isn't a string we're gonna pull this one in anyway.

@thecrypticace thecrypticace merged commit fac8cd9 into tailwindlabs:main Jul 11, 2025
7 checks passed
@thecrypticace
Copy link
Contributor

Aside: the screenshot is compiled v3 code — not v4. We could make this change for v3 as well if absolutely necessary.

@okxiaoliang4 okxiaoliang4 deleted the patch-1 branch July 27, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants