Ensure changing the immediate prop on the Combobox component is reflected in the component
#3792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a small wrapper around `useMemo` with the only goal of getting a stable object out unless an value in the object changes. We are not using the `useMemo` hook to optimize expensive calculations at all. This hook has 2 benefits: 1. Type safe — you will get a type error if you are missing some property (or add one that shouldn't exist) 2. The dependencies array is always properly up to date based on the values of the object. We rely on `Object.values` returning the values in the same order.
We were using separate variables to make the object key and dependency value of `useMemo` a bit easier but that's not necessary anymore.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the changing the
immediateprop value on theComboboxcomponent didn't always reflect in the expected behavior, but only after other state changed.This was a
useMemodependency issue. I also added a newuseSlotinternal hook that ensures the value and dependency array is always up to date since we don't really care about optimizing the slot values but we just want a stable reference back instead.Fixes: #3659