Fix 'Invalid prop data-headlessui-state supplied to React.Fragment' warning
#3788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In React 19, this `Component === Fragment` check was false for some
reason. Looking at them at runtime, shows this behavior in both React 18
and React 19
```ts
let x = <Fragment></Fragment> // Instance of a Fragment
let y = <></> // Instance of a Fragment
let z = Fragment // Fragment itself
console.log(x.type === Symbol.for('react.fragment')) // true
console.log(y.type === Symbol.for('react.fragment')) // true
console.log(z === Symbol.for('react.fragment')) // true
```
We could potentially keep forwarding the props in case you have:
```ts
<Menu>
<MenuButton>
<>
<>
<>
<>
<button>To here</button>
</>
</>
</>
</>
</MenuButton>
</Menu>
```
But we can do that in a followup PR _if_ it's needed...
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in React 19 where a warning is shown in the console:
This PR fixes that by doing 2 things:
Fragment. We were relying on identity, but will now also check the underlying symbol.Fragmenteither.Test plan
where we can't reproduce the warning)
Before:
After:
Fixes: #3597
Fixes: #3351