Skip to content

Conversation

szagoruyko
Copy link
Owner

Address #83

@szagoruyko
Copy link
Owner Author

@leo-ware packaging seems like a better solution according to PEP 632 let me know if it fixes your issue

@albanD
Copy link
Contributor

albanD commented Feb 5, 2025

Hey @szagoruyko !
I added CD flows to my fork to update the release on pypi since I didn't get a chance to hear from you until early Dec.
Should I send a PR to move these back here?

@leo-ware
Copy link

leo-ware commented Feb 6, 2025

Hi @szagoruyko, sorry for the slow response. Stuff has been crazy with school.

Switching to setuptools works for me if desired functionality can be achieved. I just installed torchviz 0.0.3 and it still seems to have the distutils issue.

If I recall correctly, the advantage of looseversion was that it would remove the dependency on distutils and work as a drop in replacement for the one function that is imported.

The key line is here https://github.com/szagoruyko/pytorchviz/blob/master/torchviz/dot.py#L65. An alternative would be to simply remove the if statement (lines 65-70), as it only causes a warning, and it is only required for compatibility with torch <1.9, which was released in 2021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants