Fix support for trailing commas in tuples within generic arguments #3153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
calda
commented
Sep 20, 2025
| baaz: String, | ||
| )>() | ||
| """, | ||
| substructure: FunctionCallExprSyntax( |
There was a problem hiding this comment.
Had to include the substructure: because this test case succeeded as-is without the fix, even though the parsed output was incorrect:
assertParse(
"""
let _ = Array<(
bar: String,
baaz: String,
)>()
"""
)
calda
changed the title
|
swiftlang/swift#84421 |
|
Regarding the "Format check" failure, please run |
calda
force-pushed
the
cal--trailing-comma-in-tuple-in-generic-argument
branch
from
af713f4 to
d27e1e3
Compare
|
done, thanks! |
|
swiftlang/swift#84421 |
|
swiftlang/swift#84421 |
|
swiftlang/swift#84421 |
|
swiftlang/swift#84421 |
rintaro
approved these changes
Sep 23, 2025
|
Thanks @rintaro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes support for trailing commas in tuples within generic arguments.
This currently fails to compile in Swift 6.2 due to being parsed incorrectly. The type lookahead returns
falseso it confuses the<for a less-than operator.Corresponding compiler PR: swiftlang/swift#84421