Skip to content

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 28, 2025

Description:

This PR adds an early return to code paths to make them throw an object on error.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Feb 28, 2025
@kdy1 kdy1 self-assigned this Feb 28, 2025
@kdy1 kdy1 requested a review from a team as a code owner February 28, 2025 01:14
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 28, 2025
Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: c659281

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) February 28, 2025 01:14
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 28, 2025
@kdy1 kdy1 disabled auto-merge February 28, 2025 01:55
@kdy1 kdy1 merged commit 010ff2a into main Feb 28, 2025
169 checks passed
@kdy1 kdy1 deleted the kdy1/10087 branch February 28, 2025 01:55
Copy link

codspeed-hq bot commented Feb 28, 2025

CodSpeed Performance Report

Merging #10122 will degrade performances by 4.67%

Comparing kdy1/10087 (c659281) with main (2304cd8)

Summary

⚡ 1 improvements
❌ 3 regressions
✅ 187 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/moment 103.8 ms 108.8 ms -4.67%
es/lints/libs/d3 28.9 ms 27.7 ms +4.21%
es/minifier/libs/jquery 127.9 ms 133.4 ms -4.07%
es/minifier/libs/moment 81.4 ms 84.5 ms -3.61%

@kdy1 kdy1 modified the milestones: Planned, v1.11.5 Feb 28, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

@swc/wasm-typescript does throw object in transform mode
1 participant