Skip to content

Conversation

o-santi
Copy link
Contributor

@o-santi o-santi commented Aug 22, 2025

What kind of change does this PR introduce?

Add storage-py to the monorepo.

Additional context

  • Add it as an entry to the workspace in pyproject.toml
  • Copy the relevant files to src/{project_name} (including CHANGELOG.md, LICENSE and Makefile!)
  • Use the package directly from workspace in src/supabase, instead of from pypi.
  • Add its tests to the main Makefile, and the directory itself to make publish.
  • For projects using unasync-cli, switch away from it.
  • Add it to release please
  • Add it to main README.md

In order to make supabase cli work with multiple projects, I manually altered both src/storage/tests/tests.env and src/storage/infra/supabase/config.toml to use different ports for the project. I chose ports starting with 55 instead of 54 as used in realtime, and intend to keep this pattern for the other two packages remaining (56 and 57).

Also, storage/tests/_async as they were did not work with pytest-asyncio >= 0.21.2 (required by the other packages), even though it was marked as working, due to its heavy usage of fixture scopes and its interaction with event loops. Thusly, I temporarily removed all scopes and the event loop special casing, and we can consider re-introducing it in the future if it is needed. As far as I understand, they are simply a performance improvement, and aren't needed for test correctness. If this assumption is wrong, please let me know.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17210924165

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 93.456%

Totals Coverage Status
Change from base Build 17128526037: 2.7%
Covered Lines: 3342
Relevant Lines: 3576

💛 - Coveralls

@o-santi o-santi merged commit d4395a2 into supabase:main Aug 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants