chore: include storage-py into monorepo #1211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add
storage-py
to the monorepo.Additional context
pyproject.toml
src/{project_name}
(includingCHANGELOG.md
,LICENSE
andMakefile
!)src/supabase
, instead of from pypi.Makefile
, and the directory itself tomake publish
.unasync-cli
, switch away from it.In order to make
supabase
cli work with multiple projects, I manually altered bothsrc/storage/tests/tests.env
andsrc/storage/infra/supabase/config.toml
to use different ports for the project. I chose ports starting with55
instead of54
as used in realtime, and intend to keep this pattern for the other two packages remaining (56 and 57).Also,
storage/tests/_async
as they were did not work withpytest-asyncio >= 0.21.2
(required by the other packages), even though it was marked as working, due to its heavy usage of fixturescope
s and its interaction with event loops. Thusly, I temporarily removed all scopes and the event loop special casing, and we can consider re-introducing it in the future if it is needed. As far as I understand, they are simply a performance improvement, and aren't needed for test correctness. If this assumption is wrong, please let me know.