Skip to content

Fix ChannelTopic init from string and add unit tests #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2022
Merged

Fix ChannelTopic init from string and add unit tests #5

merged 1 commit into from
Feb 21, 2022

Conversation

grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Feb 21, 2022

I created this PR in favor of #4 . Thanks @lmick002 for addressing it, I've just added a few minor things on top of it, such as:

  1. Refactoring ChannelTopic type for using RawRepresentable.
  2. Add unit tests for testing the ChannelTopic init from the rawValue string.

Fixes #3

@grdsdev grdsdev merged commit 2b55564 into main Feb 21, 2022
@grdsdev grdsdev deleted the fix/channel-topic-creation branch February 21, 2022 09:48
@grdsdev grdsdev mentioned this pull request Feb 21, 2022
Closed
@grdsdev grdsdev mentioned this pull request Mar 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue With Channel + Schema
1 participant
@grdsdev