⚡️(frontend) improve export table width calculation #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
added
bug
Sometimes we do not have the width of some columns in a table. In such cases, we need to calculate a fallback width to ensure the table is rendered correctly. We were previously using 120 points as the fallback width, but this has been improved to better fit the content. We now check the size left and distribute it among the unknown columns.
AntoLC
force-pushed
the
fix/table-pdf-export
branch
from
9706ae6 to
726b50d
Compare
|
Size Change: +63 B (0%) Total Size: 3.64 MB
|
|
Linking the BlockNote issue I opened : TypeCellOS/BlockNote#1979 |
AntoLC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sometimes we do not have the width of some columns in a table. In such cases, we need to calculate a fallback width to ensure the table is rendered correctly.
Proposal
We were previously using 120 points as the fallback width, but this has been improved to better fit the content.
We now check the size left and distribute it among the unknown columns.
Demo
Before:
After