Skip to content

🌐(frontend) set html lang attribute dynamically based on current loc #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

🌐(frontend) set html lang attribute dynamically based on current loc #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ and this project adheres to
- ♻️(frontend) redirect to doc after duplicate #1175
- 🔧(project) change env.d system by using local files #1200
- ⚡️(frontend) improve tree stability #1207
- ⚡️(frontend) improve accessibility #1232
- ⚡️(frontend) improve accessibility
- #1232
- #1248
- 🛂(frontend) block drag n drop when not desktop #1239

### Fixed
Expand Down
6 changes: 6 additions & 0 deletions src/frontend/apps/e2e/__tests__/app-impress/language.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ test.describe.serial('Language', () => {
test('checks language switching', async ({ page }) => {
const header = page.locator('header').first();

await expect(page.locator('html')).toHaveAttribute('lang', 'en-us');

// initial language should be english
await expect(
page.getByRole('button', {
Expand All @@ -36,6 +38,8 @@ test.describe.serial('Language', () => {
// switch to french
await waitForLanguageSwitch(page, TestLanguage.French);

await expect(page.locator('html')).toHaveAttribute('lang', 'fr');

await expect(
header.getByRole('button').getByText('Français'),
).toBeVisible();
Expand All @@ -47,6 +51,8 @@ test.describe.serial('Language', () => {
await expect(header.getByRole('button').getByText('Deutsch')).toBeVisible();

await expect(page.getByLabel('Abmelden')).toBeVisible();

await expect(page.locator('html')).toHaveAttribute('lang', 'de');
});

test('checks that backend uses the same language as the frontend', async ({
Expand Down
1 change: 1 addition & 0 deletions src/frontend/apps/impress/src/i18n/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const fallbackLng = 'en';
14 changes: 13 additions & 1 deletion src/frontend/apps/impress/src/i18n/initI18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import i18next from 'i18next';
import LanguageDetector from 'i18next-browser-languagedetector';
import { initReactI18next } from 'react-i18next';

import { fallbackLng } from './config';
import resources from './translations.json';

// Add an initialization guard
Expand All @@ -16,7 +17,7 @@ if (!isInitialized && !i18next.isInitialized) {
.use(initReactI18next)
.init({
resources,
fallbackLng: 'en',
fallbackLng,
debug: false,
detection: {
order: ['cookie', 'navigator'],
Expand All @@ -35,6 +36,17 @@ if (!isInitialized && !i18next.isInitialized) {
nsSeparator: false,
keySeparator: false,
})
.then(() => {
if (typeof document !== 'undefined') {
document.documentElement.setAttribute(
'lang',
i18next.language || fallbackLng,
);
i18next.on('languageChanged', (lang) => {
document.documentElement.setAttribute('lang', lang);
});
}
})
.catch((e) => console.error('i18n initialization failed:', e));
}

Expand Down
44 changes: 32 additions & 12 deletions src/frontend/apps/impress/src/pages/_document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,33 @@
import { Head, Html, Main, NextScript } from 'next/document';

export default function RootLayout() {
return (
<Html>
<Head />
<body suppressHydrationWarning={process.env.NODE_ENV === 'development'}>
<Main />
<NextScript />
</body>
</Html>
);
import Document, {
DocumentContext,
Head,
Html,
Main,
NextScript,
} from 'next/document';

import { fallbackLng } from '../i18n/config';

class MyDocument extends Document<{ locale: string }> {
static async getInitialProps(ctx: DocumentContext) {
const initialProps = await Document.getInitialProps(ctx);
return {
...initialProps,
locale: ctx.locale || fallbackLng,
};
}

render() {
return (
<Html lang={this.props.locale}>
<Head />
<body>
<Main />
<NextScript />
</body>
</Html>
);
}
}

export default MyDocument;
Loading