-
Notifications
You must be signed in to change notification settings - Fork 298
Add iOS patch info to README #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
After 62f5bf6, the patch workaround should not be needed anymore |
``` | ||
|
||
If possible, update to version 0.52 or above of the Stripe React Native SDK. | ||
If you are unable to do so, please follow our [guide to apply the fix patch](https://github.com/stripe/stripe-react-native/tree/master/patches). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we just delete the patch now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually maybe keep it, we have a user integrating who was using it just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea let’s keep it for a little bit longer just in case.
patches/README.md
Outdated
|
||
## The Solution | ||
|
||
If possible, update to version 0.52 or above of the Streip React Native SDK. If you are unable to do so, use the `old-arch-codegen-fix` patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in "Streip"
Summary
We frequently get people filing GitHub issues for the known iOS old architecture RN 0.74+ issue that can be solved with the patch guide. Adding info to the README to make this more visible so that users can self-solve
Motivation
N/A
Testing
N/A
Documentation
Select one: