Halve FC memory usage #3628
Draft
Halve FC memory usage #3628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
force-pushed
the
fc-half
branch
4 times, most recently
from
1c26462 to
dffaf55
Compare
arnetheduck
force-pushed
the
fc-half
branch
2 times, most recently
from
a627026 to
95e3e1d
Compare
arnetheduck
force-pushed
the
fc-half
branch
5 times, most recently
from
5bf134c to
4cfa1d8
Compare
Making the two projects more similar makes it easier to maintain a cohesive user experience over time: * remove metrics logging - this is not viable for the amount of metrics that we have (no other project has this either) * remove `EthContext` - looks like a refactoring leftover * reuse more `nimbus_binary_common` utilities instead of homegrown versions * bump eth2
arnetheduck
force-pushed
the
fc-half
branch
from
4cfa1d8 to
abba6f2
Compare
arnetheduck
force-pushed
the
fc-half
branch
from
abba6f2 to
89754de
Compare
Blocks are getting stored both in BlockRef and in TxFrame - this is the less invasive change that delays storing block contents in TxFrame until it's time to update the base - the better option for the future is likely to not store the full block in BlockRef (and instead load it from TxFrame on demand)
arnetheduck
force-pushed
the
fc-half
branch
from
89754de to
554a991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocks are getting stored both in BlockRef and in TxFrame - this is the less invasive change that delays storing block contents in TxFrame until it's time to update the base - the better option for the future is likely to not store the full block in BlockRef (and instead load it from TxFrame on demand)