Add validation in reconciliation workflow

Author: rehanjaved237

api/v1alpha1/channel_webhook.go

@@ -55,7 +55,7 @@ func (r *Channel) ValidateUpdate(old runtime.Object) error {
 	if !ok {
 		return fmt.Errorf("Error casting old runtime object to %T from %T", oldChannel, old)
 	}
-	return validateImmutableFields(r, oldChannel)
+	return ValidateImmutableFields(r, oldChannel)
 }
 
 // ValidateDelete implements webhook.Validator so a webhook will be registered for the type
@@ -66,7 +66,7 @@ func (r *Channel) ValidateDelete() error {
 }
 
 // TODO: test & write tst
-func validateImmutableFields(newChannel *Channel, oldChannel *Channel) error {
+func ValidateImmutableFields(newChannel *Channel, oldChannel *Channel) error {
 	if oldChannel.Spec.Private != newChannel.Spec.Private {
 		return fmt.Errorf("Field 'isPrivate' is immutable and cannot be changed after Slack Channel has been created")
 	}

controllers/channel_controller.go

@@ -109,6 +109,14 @@ func (r *ChannelReconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
 		return r.updateSlackChannel(ctx, channel)
 	}
 
+	existingChannel, err := r.SlackService.GetChannel(channel.Status.ID)
+	existingChannelCR := r.SlackService.GetChannelCRFromChannel(existingChannel)
+
+	err = slackv1alpha1.ValidateImmutableFields(existingChannelCR, channel)
+	if err != nil {
+		return reconcilerUtil.ManageError(r.Client, channel, err, true)
+	}
+
 	return r.updateSlackChannel(ctx, channel)
 }
 

controllers/suite_test.go

@@ -103,6 +103,8 @@ var _ = BeforeSuite(func(done Done) {
 }, 60)
 
 var _ = AfterSuite(func() {
+	util.DeleteNamespace(ns)
+
 	By("tearing down the test environment")
 	err := testEnv.Stop()
 	Expect(err).ToNot(HaveOccurred())

controllers/util/testUtil.go

@@ -104,6 +104,16 @@ func (t *TestUtil) CreateNamespace(name string) {
 	}
 }
 
+// CreateNamespace creates a namespace in the kubernetes server
+func (t *TestUtil) DeleteNamespace(name string) {
+	namespaceObject := t.CreateNamespaceObject(name)
+	err := t.k8sClient.Delete(t.ctx, namespaceObject)
+
+	if err != nil {
+		ginkgo.Fail(err.Error())
+	}
+}
+
 // CreateSlackChannelObject creates a slack channel custom resource object
 func (t *TestUtil) CreateSlackChannelObject(name string, isPrivate bool, topic string, description string, users []string, namespace string) *slackv1alpha1.Channel {
 	return &slackv1alpha1.Channel{

pkg/slack/service.go

@@ -3,6 +3,8 @@ package slack
 import (
 	"github.com/go-logr/logr"
 	"github.com/slack-go/slack"
+
+	slackv1alpha1 "github.com/stakater/slack-operator/api/v1alpha1"
 )
 
 // Service interface
@@ -13,6 +15,8 @@ type Service interface {
 	RenameChannel(string, string) (*slack.Channel, error)
 	ArchiveChannel(string) error
 	InviteUsers(string, []string) error
+	GetChannel(string) (*slack.Channel, error)
+	GetChannelCRFromChannel(*slack.Channel) *slackv1alpha1.Channel
 }
 
 // SlackService structure
@@ -29,6 +33,19 @@ func New(APIToken string, logger logr.Logger) *SlackService {
 	}
 }
 
+// GetChannel gets a channel on slack
+func (s *SlackService) GetChannel(channelID string) (*slack.Channel, error) {
+	log := s.log.WithValues("channelID", channelID)
+
+	channel, err := s.api.GetConversationInfo(channelID, false)
+	if err != nil {
+		log.Error(err, "Error fetching channel")
+		return nil, err
+	}
+
+	return channel, err
+}
+
 // CreateChannel creates a public or private channel on slack with the given name
 func (s *SlackService) CreateChannel(name string, isPrivate bool) (*string, error) {
 	s.log.Info("Creating Slack Channel", "name", name, "isPrivate", isPrivate)
@@ -158,3 +175,15 @@ func (s *SlackService) InviteUsers(channelID string, userEmails []string) error
 	}
 	return nil
 }
+
+func (s *SlackService) GetChannelCRFromChannel(existingChannel *slack.Channel) *slackv1alpha1.Channel {
+	var channel slackv1alpha1.Channel
+
+	channel.Spec.Name = existingChannel.Name
+	channel.Spec.Description = existingChannel.Purpose.Value
+	channel.Spec.Topic = existingChannel.Topic.Value
+	channel.Spec.Private = existingChannel.IsPrivate
+	channel.Spec.Users = existingChannel.Members
+
+	return &channel
+}