Merge pull request #5 from stakater/fix-lint-issues

Fix lint Issues

Author: ahmedwaleedmalik

controllers/util/testUtil.go

@@ -88,10 +88,10 @@ func (t *TestUtil) DeleteChannel(name string, namespace string) {
 // TryDeleteChannel - Tries to delete channel if it exists, does not fail on any error
 func (t *TestUtil) TryDeleteChannel(name string, namespace string) {
 	channelObject := &slackv1alpha1.Channel{}
-	t.k8sClient.Get(t.ctx, types.NamespacedName{Name: name, Namespace: namespace}, channelObject)
-	t.k8sClient.Delete(t.ctx, channelObject)
+	_ = t.k8sClient.Get(t.ctx, types.NamespacedName{Name: name, Namespace: namespace}, channelObject)
+	_ = t.k8sClient.Delete(t.ctx, channelObject)
 	req := reconcile.Request{NamespacedName: types.NamespacedName{Name: name, Namespace: namespace}}
-	t.r.Reconcile(req)
+	_, _ = t.r.Reconcile(req)
 }
 
 // CreateNamespace creates a namespace in the kubernetes server

pkg/slack/mock/data.go

@@ -1,7 +1,6 @@
 package mock
 
 import (
-	"encoding/json"
 	"fmt"
 	"time"
 
@@ -111,12 +110,6 @@ func getConversationPurposeResponse(purpose string) string {
 		nowAsJSONTime(), purpose, BotID, nowAsJSONTime(), 0)
 }
 
-func getChannelPurposeResponse(purpose string) string {
-	return fmt.Sprintf(templateChannelJSON, PublicConversationID, ConversationName,
-		nowAsJSONTime(), BotID, ConversationName, "false", "random topic", BotID,
-		nowAsJSONTime(), purpose, BotID, nowAsJSONTime(), 0)
-}
-
 const ExistingUserEmail = "[email protected]"
 
 var templateUserJSON = `
@@ -171,13 +164,3 @@ var userNotFoundJSON = `
 func nowAsJSONTime() slack.JSONTime {
 	return slack.JSONTime(time.Now().Unix())
 }
-
-func asChannelObject(j string) *slack.Channel {
-	channel := &slack.Channel{}
-	err := json.Unmarshal([]byte(j), &channel)
-
-	if err != nil {
-		panic(err)
-	}
-	return channel
-}