-
-
Notifications
You must be signed in to change notification settings - Fork 593
Add csi support #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZanisO
wants to merge
8
commits into
stakater:master
Choose a base branch
from
ZanisO:add-csi-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add csi support #834
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f6887b4
Added support for CSI secret provider
ZanisO 6d1d017
Don't reload existing config
ZanisO 3c39406
Added capability to use OnChangeAnnotation and TypeAutoAnnotation
ZanisO 75f9a23
Added tests
ZanisO 717291f
Added check to see if CSI CRDs are installed before running controller
ZanisO 69b0d93
Added controller tests
ZanisO 570649e
Minor improvements to tests and handlers
ZanisO e7e095c
Fixed tests
ZanisO File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ import ( | |
"k8s.io/client-go/util/workqueue" | ||
"k8s.io/kubectl/pkg/scheme" | ||
"k8s.io/utils/strings/slices" | ||
csiv1 "sigs.k8s.io/secrets-store-csi-driver/apis/v1" | ||
) | ||
|
||
// Controller for checking events | ||
|
@@ -79,7 +80,16 @@ func NewController( | |
} | ||
} | ||
|
||
listWatcher := cache.NewFilteredListWatchFromClient(client.CoreV1().RESTClient(), resource, namespace, optionsModifier) | ||
getterRESTClient := client.CoreV1().RESTClient() | ||
if resource == "secretproviderclasspodstatuses" { | ||
csiClient, err := kube.GetCSIClient() | ||
if err != nil { | ||
logrus.Fatal(err) | ||
} | ||
getterRESTClient = csiClient.SecretsstoreV1().RESTClient() | ||
} | ||
|
||
listWatcher := cache.NewFilteredListWatchFromClient(getterRESTClient, resource, namespace, optionsModifier) | ||
|
||
_, informer := cache.NewInformerWithOptions(cache.InformerOptions{ | ||
ListerWatcher: listWatcher, | ||
|
@@ -108,6 +118,8 @@ func (c *Controller) Add(obj interface{}) { | |
case *v1.Namespace: | ||
c.addSelectedNamespaceToCache(*object) | ||
return | ||
case *csiv1.SecretProviderClassPodStatus: | ||
return | ||
} | ||
|
||
if options.ReloadOnCreate == "true" { | ||
|
@@ -127,6 +139,8 @@ func (c *Controller) resourceInIgnoredNamespace(raw interface{}) bool { | |
return c.ignoredNamespaces.Contains(object.ObjectMeta.Namespace) | ||
case *v1.Secret: | ||
return c.ignoredNamespaces.Contains(object.ObjectMeta.Namespace) | ||
case *csiv1.SecretProviderClassPodStatus: | ||
return c.ignoredNamespaces.Contains(object.ObjectMeta.Namespace) | ||
} | ||
return false | ||
} | ||
|
@@ -145,6 +159,10 @@ func (c *Controller) resourceInSelectedNamespaces(raw interface{}) bool { | |
if slices.Contains(selectedNamespacesCache, object.GetNamespace()) { | ||
return true | ||
} | ||
case *csiv1.SecretProviderClassPodStatus: | ||
if slices.Contains(selectedNamespacesCache, object.GetNamespace()) { | ||
return true | ||
} | ||
} | ||
return false | ||
} | ||
|
@@ -183,6 +201,13 @@ func (c *Controller) Update(old interface{}, new interface{}) { | |
|
||
// Delete function to add an object to the queue in case of deleting a resource | ||
func (c *Controller) Delete(old interface{}) { | ||
switch object := old.(type) { | ||
case *v1.Namespace: | ||
c.removeSelectedNamespaceFromCache(*object) | ||
return | ||
case *csiv1.SecretProviderClassPodStatus: | ||
return | ||
} | ||
|
||
if options.ReloadOnDelete == "true" { | ||
if !c.resourceInIgnoredNamespace(old) && c.resourceInSelectedNamespaces(old) && secretControllerInitialized && configmapControllerInitialized { | ||
|
@@ -193,12 +218,6 @@ func (c *Controller) Delete(old interface{}) { | |
}) | ||
} | ||
} | ||
|
||
switch object := old.(type) { | ||
case *v1.Namespace: | ||
c.removeSelectedNamespaceFromCache(*object) | ||
return | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moving this |
||
} | ||
} | ||
|
||
// Run function for controller which handles the queue | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to invert the setting as to having it enabled if no option is supplied?
if options.DisableCSIIntegration