-
Notifications
You must be signed in to change notification settings - Fork 116
change the default behaviour of proxyrunner #1952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
+ Coverage 47.01% 47.32% +0.31%
==========================================
Files 223 233 +10
Lines 27659 28661 +1002
==========================================
+ Hits 13005 13565 +560
- Misses 13653 14080 +427
- Partials 1001 1016 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2614378
to
2f89f83
Compare
When using toolhive_use_configmap the operator will create a volume mount from the configmap, in the matching pod. Then proxyrunner needs to check if that file exists, and read the config from there instead of the old --from-configmap behaviour Closes: #1947
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request changes the default behavior of the proxy runner to use file-based configuration discovery instead of the deprecated --from-configmap
flag. The operator now volume mounts ConfigMaps to standard filesystem locations, and the proxy runner automatically searches for and loads runconfig.json
from these predefined paths.
Key changes:
- Removed the
--from-configmap
flag and replaced it with automatic file discovery - Added volume mounting of ConfigMaps in the operator when
TOOLHIVE_USE_CONFIGMAP=true
- Updated all test scenarios to verify volume mounting instead of the removed flag
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
cmd/thv-proxyrunner/app/run.go |
Replaced --from-configmap flag with automatic file-based configuration discovery |
cmd/thv-proxyrunner/app/run_test.go |
Updated tests to remove ConfigMap flag validation and add file-based configuration tests |
cmd/thv-operator/controllers/mcpserver_controller.go |
Added volume mounting for ConfigMaps instead of using --from-configmap flag |
pkg/runner/config_builder.go |
Added individual transport configuration methods (WithTransport , WithPort , WithTargetPort ) |
pkg/runner/config_builder_test.go |
Added comprehensive tests for the new individual transport configuration methods |
Test files | Updated all test scenarios to validate volume mounting instead of the deprecated flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bddfd85
to
83d3ffe
Compare
When using toolhive_use_configmap the operator will create a volume mount from the configmap, in the matching pod. Then proxyrunner needs to check if that file exists, and read the config from there instead of the old --from-configmap behaviour
Closes: #1947