Skip to content

Conversation

ChrisJBurns
Copy link
Collaborator

  • Rename port to proxyPort - represents proxy runner port
  • Rename targetPort to mcpPort - represents MCP server port

This change addresses user confusion about port semantics as discussed in issue #1452. The new names clearly indicate which port corresponds to which component:

  • proxyPort: Port exposed by the proxy runner in Kubernetes
  • mcpPort: Port that the MCP server listens on internally

Updated all relevant files:

  • CRD types definition and generated YAML
  • Operator controller logic
  • All example and test YAML files
  • Keycloak deployment example

🤖 Generated with Claude Code

claude bot and others added 2 commits August 27, 2025 10:27
- Rename `port` to `proxyPort` - represents proxy runner port
- Rename `targetPort` to `mcpPort` - represents MCP server port

This change addresses user confusion about port semantics as discussed
in issue #1452. The new names clearly indicate which port corresponds
to which component:
- proxyPort: Port exposed by the proxy runner in Kubernetes
- mcpPort: Port that the MCP server listens on internally

Updated all relevant files:
- CRD types definition and generated YAML
- Operator controller logic
- All example and test YAML files
- Keycloak deployment example

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Chris Burns <[email protected]>
jhrozek
jhrozek previously approved these changes Sep 9, 2025
@jhrozek
Copy link
Contributor

jhrozek commented Sep 9, 2025

lol, I approved before looking at the CI run 🤦🏻

@ChrisJBurns
Copy link
Collaborator Author

I'll pull it locally and run the docs steps

@ChrisJBurns ChrisJBurns changed the title Rename MCPServer CRD port attributes for clarity Rename MCPServer CRD Port Attributes for Clarity Sep 18, 2025
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.29%. Comparing base (3a3ff50) to head (7badebd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...d/thv-operator/controllers/mcpserver_controller.go 35.71% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
- Coverage   47.29%   47.29%   -0.01%     
==========================================
  Files         223      223              
  Lines       27681    27681              
==========================================
- Hits        13092    13091       -1     
- Misses      13591    13593       +2     
+ Partials      998      997       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants