Skip to content

Make requests to the VM's methods reject after a given period of time if no answer is forthcoming from the iframe #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Make requests to the VM's methods reject after a given period of time if no answer is forthcoming from the iframe #12

wants to merge 6 commits into from

Conversation

emilefokkema
Copy link

This fixes #11 . It extends the public API somewhat to allow passing requestTimeout?: number as part of the options object.

@emilefokkema
Copy link
Author

@fvsch or @apai4 What do you think of this idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A Promise returned from one of the VM's methods fails to settle if the request encounters an error on the page inside the iframe
1 participant
@emilefokkema