Update Squiz.CSS.DuplicateClassDefinitionSniff #2639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove comments from class names, before searching for @media and checking for duplicates.
|
The test cases in this PR pass without any modification to the sniff itself, so they are not replicating the problem that the PR aims to solve. I will take a look into them a bit more and see if I can figure out what's going on. |
|
Ah, I see what went wrong. The comments in the test file are all the same, so they always look like they match. I will change them to ensure the current code sees them as different classes. |
gsherwood
added a commit
that referenced
this pull request
Oct 30, 2019
|
Thanks for the PR. Fix worked well after the tests were changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove comments from class names, before searching for
@mediaand checking for duplicates.This closes #2638.
The fix of #1657 is still in place.