Skip to content

Polish DefaultLoginPageGeneratingFilter #12657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2023
Merged

Polish DefaultLoginPageGeneratingFilter #12657

merged 3 commits into from
Feb 16, 2023

Conversation

twosom
Copy link
Contributor

@twosom twosom commented Feb 11, 2023

This PR has refactored the DefaultLoginPageGeneratingFilter class.

  • Some private static methods have been changed to non-static methods.
  • Changed the initAuthFilter method to use instanceof pattern matching.
  • Refactored the error message extraction in the generateLoginPageHtml method.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 11, 2023
@jzheaux jzheaux self-assigned this Feb 15, 2023
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 15, 2023
@jzheaux jzheaux force-pushed the polish-default-login-page-generating-filter branch from cc77172 to b100cff Compare February 15, 2023 22:18
@jzheaux jzheaux added this to the 6.1.0-M2 milestone Feb 15, 2023
@jzheaux jzheaux merged commit 28d353d into spring-projects:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M2
Development

Successfully merging this pull request may close these issues.
3 participants
@twosom @jzheaux @spring-projects-issues