Skip to content

Replace StringUtils class of oauth2-oidc-sdk completely #10805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Replace StringUtils class of oauth2-oidc-sdk completely #10805

wants to merge 1 commit into from

Conversation

giger85
Copy link
Contributor

@giger85 giger85 commented Feb 3, 2022

origin Issue: #9925

In spring-security-samples repo, a sample module uses com.nimbusds:oauth2-oidc-sdk dependency.

dependencies {
	implementation 'com.nimbusds:oauth2-oidc-sdk'
}

This change replaces StringUtils class of oauth2-oidc-sdk completely.
If this pr is accepted, then I am able to remove oauth2-oidc-sdk dependency of opaque example.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 3, 2022
@eleftherias eleftherias self-assigned this Feb 4, 2022
@eleftherias eleftherias added in: test An issue in spring-security-test type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 4, 2022
@eleftherias eleftherias added this to the 5.7.0-M2 milestone Feb 7, 2022
eleftherias pushed a commit that referenced this pull request Feb 7, 2022
@giger85 @eleftherias
Replace StringUtils class completely
4a3654a 
Issue gh-9925
Closes gh-10805
@eleftherias
Copy link
Contributor

Thanks for the PR @giger85!
This has been merged 4a3654a.

@eleftherias eleftherias closed this Feb 7, 2022
eleftherias pushed a commit that referenced this pull request Feb 7, 2022
@giger85 @eleftherias
Replace StringUtils class completely
440e890 
Issue gh-9925
Closes gh-10805
@giger85
Copy link
Contributor Author

giger85 commented Feb 8, 2022

@eleftherias
Thanks for your review.
I will prepare another PR in spring-security-samples repository.

@giger85 giger85 deleted the feature/replace-string-utils branch February 8, 2022 14:23
@eleftherias eleftherias mentioned this pull request Feb 10, 2022
Closed
eleftherias pushed a commit that referenced this pull request Feb 10, 2022
@giger85 @eleftherias
Replace StringUtils class completely
8f01efb 
Issue gh-9925
Closes gh-10805
@eleftherias eleftherias mentioned this pull request Feb 10, 2022
Closed
eleftherias pushed a commit that referenced this pull request Feb 10, 2022
@giger85 @eleftherias
Replace StringUtils class completely
304ef23 
Issue gh-9925
Closes gh-10805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eleftherias eleftherias

Labels
in: test An issue in spring-security-test type: bug A general bug
Projects
None yet
Milestone
5.7.0-M2
Development

Successfully merging this pull request may close these issues.
3 participants
@giger85 @eleftherias @spring-projects-issues