Skip to content

Allow update of existing WebSession after max sessions limit is reached #35013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Allow update of existing WebSession after max sessions limit is reached #35013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de0e0c8
Fix: Allow session update when session ID already exists even if max …
Jun 8, 2025
25e6642
Test case for Allow session update for existing session ID even if ma…
Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spring-web/src/main/java/org/springframework/web/server/session/InMemoryWebSessionStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ public Mono<Void> save() {
private void checkMaxSessionsLimit() {
if (sessions.size() >= maxSessions) {
expiredSessionChecker.removeExpiredSessions(clock.instant());
if (sessions.size() >= maxSessions) {
if (sessions.size() >= maxSessions && !sessions.containsKey(this.getId())) {
throw new IllegalStateException("Max sessions limit reached: " + sessions.size());
}
}
Expand Down
20 changes: 20 additions & 0 deletions ...eb/src/test/java/org/springframework/web/server/session/InMemoryWebSessionStoreTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
import reactor.test.StepVerifier;

/**
* Tests for {@link InMemoryWebSessionStore}.
Expand Down Expand Up @@ -159,6 +160,25 @@ void maxSessions() {
.withMessage("Max sessions limit reached: 10000");
}

@Test
void updateSession() {
WebSession oneWebSession = insertSession();

StepVerifier.create(oneWebSession.save())
.expectComplete()
.verify();
}

@Test
void updateSession_whenMaxSessionsReached() {
WebSession onceWebSession = insertSession();
IntStream.range(1, 10000).forEach(i -> insertSession());

StepVerifier.create(onceWebSession.save())
.expectComplete()
.verify();
}

private WebSession insertSession() {
WebSession session = this.store.createWebSession().block();
assertThat(session).isNotNull();
Expand Down