Skip to content

PropertySourcesPlaceholderConfigurer no longer uses ConversionService from Environment #34936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

PropertySourcesPlaceholderConfigurer no longer uses ConversionService from Environment #34936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...c/main/java/org/springframework/context/support/PropertySourcesPlaceholderConfigurer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ protected ConfigurablePropertyResolver createPropertyResolver(MutablePropertySou
protected void processProperties(ConfigurableListableBeanFactory beanFactoryToProcess,
ConfigurablePropertyResolver propertyResolver) throws BeansException {

if(this.environment instanceof ApplicationServletEnvironment) {
propertyResolver.setConversionService(((ApplicationServletEnvironment) this.environment).getConversionService());
}

Copy link
Member

@sbrannen sbrannen May 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (this.environment instanceof ConfigurableEnvironment configurableEnvironment) {
propertyResolver.setConversionService(configurableEnvironment.getConversionService());
}

I looked into a possible fix before looking at your proposal, and I first came up with the analogous solution above.

We cannot use ApplicationServletEnvironment here, since that class is specific to Spring Boot and Servlet deployments.

Thus, downcasting to ConfigurableEnvironment using instanceof pattern matching would be the correct way to do that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks something didn't feel right with the change I made

propertyResolver.setPlaceholderPrefix(this.placeholderPrefix);
propertyResolver.setPlaceholderSuffix(this.placeholderSuffix);
propertyResolver.setValueSeparator(this.valueSeparator);
Expand Down