-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Update AOTCache documentation to JEP 514 #47291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AOTCache documentation to JEP 514 #47291
Conversation
Signed-off-by: Ramesh <[email protected]>
8bbb2f8
to
f391536
Compare
$ java -XX:AOTMode=record -XX:AOTConfiguration=app.aotconf -Dspring.context.exit=onRefresh -jar my-app.jar | ||
$ java -XX:AOTMode=create -XX:AOTConfiguration=app.aotconf -XX:AOTCache=app.aot -jar my-app.jar | ||
$ java -XX:AOTCacheOutput=app.aot -Dspring.context.exit=onRefresh -jar my-app.jar | ||
$ java -XX:AOTCache=app.aot -jar my-app.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right to me. As I understand it, the new flags will only work with Java 25 and Spring Boot supports Java 17 and later. If that understanding is correct, the documentation will have to show two examples. One for Java 17–24 and one for Java 25.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the file please review it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AotCache (leyden) was not in java 17. It appeared with java 24
I will make the changes
…On Mon, Sep 22, 2025 at 12:17 PM Andy Wilkinson ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In
documentation/spring-boot-docs/src/docs/antora/modules/reference/pages/packaging/class-data-sharing.adoc
<#47291 (comment)>
:
> -$ java -XX:AOTMode=record -XX:AOTConfiguration=app.aotconf -Dspring.context.exit=onRefresh -jar my-app.jar
-$ java -XX:AOTMode=create -XX:AOTConfiguration=app.aotconf -XX:AOTCache=app.aot -jar my-app.jar
+$ java -XX:AOTCacheOutput=app.aot -Dspring.context.exit=onRefresh -jar my-app.jar
+$ java -XX:AOTCache=app.aot -jar my-app.jar
This doesn't look right to me. As I understand it, the new flags will only
work with Java 25 and Spring Boot supports Java 17 and later. If that
understanding is correct, the documentation will have to show two examples.
One for Java 17–24 and one for Java 25.
—
Reply to this email directly, view it on GitHub
<#47291 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQXQZR43WO65DO4NM3BB6AL3T6LRHAVCNFSM6AAAAACHCLZEFOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENJQHAZDOOBSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: Ramesh <[email protected]>
Thanks again for the PR. Unfortunately, this isn't really heading in the right direction as the latest updates aren't quite right. As is often the case with documentation changes, I think it'll be easier if a member of the core team takes care of this. Thanks anyway. |
Thank you for the update.
…On Mon, Sep 22, 2025 at 2:32 PM Andy Wilkinson ***@***.***> wrote:
*wilkinsona* left a comment (spring-projects/spring-boot#47291)
<#47291 (comment)>
Thanks again for the PR. Unfortunately, this isn't really heading in the
right direction as the latest updates aren't quite right. As is often the
case with documentation changes, I think it'll be easier if a member of the
core team takes care of this. Thanks anyway.
—
Reply to this email directly, view it on GitHub
<#47291 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQXQZRYVPMF6GJEZFFPCLWL3T63KXAVCNFSM6AAAAACHCLZEFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJXGY4TENZWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Summary
Update Spring Boot documentation to reflect JEP 514 AOT Cache flags in Java 25.
Changes Made
Motivation
Old documentation used outdated JVM flags. This update ensures docs match the new standard and are clear for users.
References