Skip to content

cpp interop changes - drop _Bool, use portable popcount and highest_bit_position implementations #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 28, 2021
Merged

cpp interop changes - drop _Bool, use portable popcount and highest_bit_position implementations #14

merged 5 commits into from
Dec 28, 2021

Conversation

spaskalev
Copy link
Owner

Fixes #13

@spaskalev spaskalev requested a review from YunHsiao December 28, 2021 14:30
@spaskalev spaskalev self-assigned this Dec 28, 2021
YunHsiao
YunHsiao reviewed Dec 28, 2021
View reviewed changes
Copy link
Contributor

@YunHsiao YunHsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, but I'm still having compiling errors reporting the stdalign.h can not be found. The header is deprecated since C++17 anyways so I think it's safe to remove it.

@spaskalev spaskalev merged commit 6daa8ea into main Dec 28, 2021
@spaskalev spaskalev deleted the cpp_interop branch December 28, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@YunHsiao YunHsiao YunHsiao left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@spaskalev spaskalev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More Compilers Support?
2 participants
@spaskalev @YunHsiao