Link references for fields, fixes #413 #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, scip-java only linked references for method symbols. This commit changes the behavior to additionally include fields so that "find references" for fields shows usages of all implementations of the field (abstract super field and concrete implementations).
olafurpg
changed the title
Previously, we used the symbol itself, which was not reliable because it didn't distinguish between fields an objects. This commit changes the logic to be based on `SymbolInformation.kind` from SemanticDB, that is a more robust and idiomatic solution. Fixes #414.
chrismwendt
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, scip-java only linked references for method symbols. This
commit changes the behavior to additionally include fields so that "find
references" for fields shows usages of all implementations of the field
(abstract super field and concrete implementations).
Test plan
See newly added snapshot test that reproduces the issue. However, the snapshot test does not render the new "reference" relationship between the sub-field and super-field (I manually verified the relationship is correct by running
scip snapshotlocally).https://sourcegraph.com/github.com/sourcegraph/sbt-sourcegraph@9ad1fc3cd0cd111552f99db1d0d869ecdf82d26d/-/blob/example/i413.scala?L12:25#tab=references
We should consider updating the snapshot format to mirror the new
scipcli tool