fix: SVGs are filled with black instead of none (#2693) #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ClaudiuHBann wants to merge 3 commits into software-mansion:main from ClaudiuHBann:@ClaudiuHBann/fix-issue-2693

ClaudiuHBann commented Jul 31, 2025 •

edited

Loading

Summary

This PR truly fixes issue #2693 😄

Those changes fix multiple bugs:

extractedProps were not forwarded to children of RNSVGGroup
colors coming from AST were already brushes
fill was not appended to the propList when defaultFill was used

Test Plan

Run any test involving SVG string parsing on Windows.

Compatibility

OS	Implemented
Windows	✅
iOS	✅
MacOS	✅
Android	✅
Web	✅

Checklist

I have tested this on a device and a simulator
I added documentation in README.md
I updated the typed files (typescript)
I added a test for the API in the __tests__ folder

ClaudiuHBann added 3 commits

August 1, 2025 01:24


          fix: forward extracted properties to children of RNSVGGroup

22bfa10


          fix: avoid extracting brush if color is already a brush, such as when…

11e7b27

… parsed from AST


          fix: always append 'fill' to propList, even when defaultFill is used

a6c9926

Author

ClaudiuHBann commented Jul 31, 2025

@bohdanprog, would you mind reviewing this PR when you have time? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet