fix: re-create cgroups when restarting runners #11792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
reviewed
Sep 9, 2025
internal/app/machined/pkg/system/runner/containerd/containerd.go
Outdated
Show resolved
Hide resolved
smira
approved these changes
Sep 9, 2025
dsseng
force-pushed
the
fix-11785-recreate-cgroups
branch
from
f4c34c7 to
3de69a5
Compare
frezbo
reviewed
Sep 9, 2025
frezbo
approved these changes
Sep 9, 2025
shanduur
approved these changes
Sep 9, 2025
smira
reviewed
Sep 9, 2025
internal/app/machined/pkg/system/runner/containerd/containerd.go
Outdated
Show resolved
Hide resolved
smira
reviewed
Sep 9, 2025
smira
reviewed
Sep 9, 2025
smira
reviewed
Sep 9, 2025
dsseng
force-pushed
the
fix-11785-recreate-cgroups
branch
from
3de69a5 to
562b05f
Compare
frezbo
reviewed
Sep 12, 2025
frezbo
reviewed
Sep 12, 2025
frezbo
reviewed
Sep 12, 2025
Make sure processes are only launched into freshly-created cgroups with all limits set when they are restarted. This also allows processes to restart after cgroup being killed via the cgroup.kill mechanism. Fixes siderolabs#11785 Signed-off-by: Dmitrii Sharshakov <[email protected]>
dsseng
force-pushed
the
fix-11785-recreate-cgroups
branch
from
562b05f to
69ab076
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure processes are only launched into freshly-created cgroups
with all limits set when they are restarted.
This also allows processes to restart after cgroup being killed via the
cgroup.kill mechanism.
Fixes #11785
Signed-off-by: Dmitrii Sharshakov [email protected]