Allow configuration of Apache HTTP MaxRequestsPerChild and MaxKeepAliveRequests #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configurable via environment variables
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
phracek
reviewed
Mar 8, 2021
phracek
reviewed
Mar 8, 2021
phracek
reviewed
Mar 8, 2021
phracek
requested changes
Mar 8, 2021
Co-authored-by: Petr Hracek <[email protected]>
|
Done, suggestions applied and removed changes to old php version images. |
|
Thanks for the fixes. LGTM. Let's wait for tests. [test][test-openshift] |
|
The two failing tests seem to be CI infrastructure-related (permissions issues?) |
|
[test-openshift][test] |
|
Issue with OpenShift 3 is here: #328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache HTTP configuration values for
MaxRequestsPerChildandMaxKeepAliveRequestsare hardcoded to4000and100respectively. My team has a need to significantly lower theMaxRequestsPerChildvalue to combat memory leakage issues. I madeMaxKeepAliveRequestsalso configurable while I was at it so everything in50-mpm-tuning.confis now configurable via environment variables. The default values have been preserved so there should be zero impact to current users. README files have been updated to add the new config options.