Skip to content

Enable nodejs24 for cXs #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Enable nodejs24 for cXs #500

wants to merge 4 commits into from

Conversation

hhorak
Copy link
Member

@hhorak hhorak commented Sep 5, 2025 •
edited by github-actions bot
Loading

No description provided.

@hhorak
Copy link
Member Author

hhorak commented Sep 5, 2025

[test]

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2025 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
RHEL9 - 24RHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:20:4220min 57stest pipeline
RHEL10 - 22RHEL-10-Nightlyx86_64✅ passed10.09.2025 12:22:2015min 50stest pipeline
RHEL9 - FIPS Enabled - 22RHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 11:46:4027min 55stest pipeline
RHEL9 - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:22:2319min 27stest pipeline
RHEL10 - 22-minimalRHEL-10-Nightlyx86_64✅ passed10.09.2025 12:37:2715min 30stest pipeline
RHEL9 - FIPS Enabled - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 11:33:4226min 32stest pipeline
RHEL9 - FIPS Enabled - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:02:0324min 11stest pipeline
RHEL10 - FIPS Enabled - 24RHEL-10-Nightlyx86_64❌ error10.09.2025 11:33:4113min 12stest pipeline
CentOS Stream 9 - 24-minimalCentOS-Stream-9x86_64✅ passed10.09.2025 12:28:5812min 4stest pipeline
Fedora - 24Fedora-latestx86_64✅ passed10.09.2025 12:18:5210min 47stest pipeline
CentOS Stream 9 - 24CentOS-Stream-9x86_64✅ passed10.09.2025 12:00:3013min 4stest pipeline
CentOS Stream 10 - 22CentOS-Stream-10x86_64✅ passed10.09.2025 12:22:2610min 57stest pipeline
CentOS Stream 10 - 24CentOS-Stream-10x86_64✅ passed10.09.2025 12:27:2412min 51stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed10.09.2025 12:31:268min 35stest pipeline
RHEL10 - FIPS Enabled - 24-minimalRHEL-10-Nightlyx86_64❌ error10.09.2025 11:33:4313min 30stest pipeline
RHEL10 - FIPS Enabled - 22-minimalRHEL-10-Nightlyx86_64✅ passed10.09.2025 11:33:3717min 17stest pipeline
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64✅ passed10.09.2025 12:38:4510min 34stest pipeline
Fedora - 24-minimalFedora-latestx86_64✅ passed10.09.2025 12:06:309min 7stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed10.09.2025 12:31:4510min 57stest pipeline
CentOS Stream 9 - 20CentOS-Stream-9x86_64✅ passed10.09.2025 11:47:5012min 32stest pipeline
Fedora - 20Fedora-latestx86_64✅ passed10.09.2025 11:33:4811min 18stest pipeline
CentOS Stream 10 - 24-minimalCentOS-Stream-10x86_64✅ passed10.09.2025 12:34:5010min 26stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64✅ passed10.09.2025 12:25:2511min 32stest pipeline
RHEL9 - 20RHEL-9.6.0-Nightlyx86_64❌ error10.09.2025 11:33:4221min 40stest pipeline
RHEL9 - FIPS Enabled - 24RHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 11:54:0825min 18stest pipeline
RHEL9 - 22RHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:41:0622min 46stest pipeline
RHEL9 - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:41:0219min 4stest pipeline
RHEL10 - 24RHEL-10-Nightlyx86_64❌ error10.09.2025 12:28:4511min 11stest pipeline
RHEL10 - 24-minimalRHEL-10-Nightlyx86_64❌ error10.09.2025 12:02:1312min 1stest pipeline
RHEL8 - 22RHEL-8.10.0-Nightlyx86_64✅ passed10.09.2025 12:02:5420min 5stest pipeline
RHEL8 - 20RHEL-8.10.0-Nightlyx86_64✅ passed10.09.2025 12:35:2219min 53stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed10.09.2025 12:02:0219min 21stest pipeline
RHEL10 - FIPS Enabled - 22RHEL-10-Nightlyx86_64✅ passed10.09.2025 11:33:4218min 27stest pipeline
RHEL9 - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 12:37:5019min 3stest pipeline
RHEL8 - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed10.09.2025 11:46:2818min 11stest pipeline
RHEL9 - FIPS Enabled - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 11:44:4323min 10stest pipeline
RHEL9 - FIPS Enabled - 20RHEL-9.6.0-Nightlyx86_64✅ passed10.09.2025 11:56:0324min 40stest pipeline
Fedora - 22-minimalFedora-latestx86_64✅ passed10.09.2025 11:33:519min 24stest pipeline

@phracek
Copy link
Member

phracek commented Sep 8, 2025

@hhorak Can you please also fix nodejs-24 and calling 'node' in Dockerfile? It should be on RHEL10 'node-24 -v' instead of 'node -v'. Thanks.

I guess, it can be done as a part of this pull request.

@hhorak
Copy link
Member Author

hhorak commented Sep 8, 2025

[test]

@phracek
Copy link
Member

phracek commented Sep 8, 2025

Also thing about one think. In our tests we used 'node' command, but RHEL10 provides 'node-24' instead of 'node'.
See https://github.com/sclorg/s2i-nodejs-container/blob/master/24/Dockerfile.rhel10#L60.

This is missing in 24-minimal/Dockerfile.rhel10. https://github.com/sclorg/s2i-nodejs-container/blob/master/24-minimal/Dockerfile.rhel10#L55

@phracek phracek self-requested a review September 8, 2025 09:57
phracek
phracek requested changes Sep 8, 2025
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my proposals. Thanks.

@hhorak
Copy link
Member Author

hhorak commented Sep 10, 2025 •
edited
Loading

@hhorak Can you please also fix nodejs-24 and calling 'node' in Dockerfile? It should be on RHEL10 'node-24 -v' instead of 'node -v'. Thanks.

This is a real issue, but I'll fix it differently. We need to have node and other binaries without a version, so instead of changing the check, I think I need to use rm -f instead of rm only when removing /usr/bin/node and others, as those do not exist before creating the symlink. Or maybe removing the rm call entirely.

@hhorak
Copy link
Member Author

hhorak commented Sep 10, 2025

[test]

@hhorak
Copy link
Member Author

hhorak commented Sep 10, 2025

[test]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek requested changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhorak @phracek