Skip to content

Use Symbol more in lint APIs #60827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2019
Merged

Use Symbol more in lint APIs #60827

merged 1 commit into from
May 27, 2019

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 14, 2019

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky match_def_path function that I added and go back to calling rustc's match_def_path method.

@jonas-schievink jonas-schievink added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2019
@nnethercote
Copy link
Contributor

@bors r+

But we need to coordinate... I'm working on more Symbol changes, e.g. #60815. I'm doing some ad hoc profiling to work out which ones are likely to affect performance. If we have multiple people doing these conversions there's a good chance there will be overlap.

@bors
Copy link
Collaborator

bors commented May 14, 2019

📌 Commit 1107158 has been approved by nnethercote

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2019
This was referenced May 15, 2019
Closed
Closed
@oli-obk
Copy link
Contributor Author

oli-obk commented May 15, 2019

Yes, I tried not to touch anything else out of that reason. I did this just to remove hacks from clippy

Centril added a commit to Centril/rust that referenced this pull request May 15, 2019
@Centril
Rollup merge of rust-lang#60827 - oli-obk:late_symbol, r=nnethercote
e40f14a 
Use `Symbol` more in lint APIs

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.
@Centril Centril mentioned this pull request May 15, 2019
Closed
bors added a commit that referenced this pull request May 15, 2019
@bors
Auto merge of #60859 - Centril:rollup-x7rcz9c, r=Centril
9620ab7 
Rollup of 9 pull requests

Successful merges:

 - #59825 (string: implement From<&String> for String)
 - #59923 (Fix convert module's documentation links)
 - #60691 (Include expression to wait for to the span of Await)
 - #60763 (Move token tree related lexer state to a separate struct)
 - #60769 (Update rustc book CLI docs.)
 - #60811 (Bump measureme dependency to 0.3)
 - #60816 (README.md: Mention MSVC 2017+, not 2013(!))
 - #60827 (Use `Symbol` more in lint APIs)
 - #60851 (Move `box` from the stable keyword to unstable keywords list)

Failed merges:

r? @ghost
@Centril
Copy link
Contributor

Centril commented May 15, 2019

Toolstate breakage in #60859 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 15, 2019
@bors
Copy link
Collaborator

bors commented May 20, 2019

☔ The latest upstream changes (presumably #60969) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented May 27, 2019

@bors r=nnethercote

@bors
Copy link
Collaborator

bors commented May 27, 2019

📌 Commit 254b9240b3608e3509a125af0f0b0cd0370109d1 has been approved by nnethercote

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2019
@bors
Copy link
Collaborator

bors commented May 27, 2019

☔ The latest upstream changes (presumably #61035) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 27, 2019
@oli-obk
Copy link
Contributor Author

oli-obk commented May 27, 2019

@bors r=nnethercote

@bors
Copy link
Collaborator

bors commented May 27, 2019

📌 Commit d6ca34c has been approved by nnethercote

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2019
Centril added a commit to Centril/rust that referenced this pull request May 27, 2019
@Centril
Rollup merge of rust-lang#60827 - oli-obk:late_symbol, r=nnethercote
32d9b74 
Use `Symbol` more in lint APIs

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.
@Centril Centril mentioned this pull request May 27, 2019
Closed
@bors
Copy link
Collaborator

bors commented May 27, 2019

⌛ Testing commit d6ca34c with merge fa40a11...

bors added a commit that referenced this pull request May 27, 2019
@bors
Auto merge of #60827 - oli-obk:late_symbol, r=nnethercote
fa40a11 
Use `Symbol` more in lint APIs

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.
@bors bors mentioned this pull request May 27, 2019
Merged
@bors
Copy link
Collaborator

bors commented May 27, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: nnethercote
Pushing fa40a11 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 27, 2019
@bors bors merged commit d6ca34c into rust-lang:master May 27, 2019
@rust-highfive rust-highfive mentioned this pull request May 27, 2019
Closed
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #60827!

Tested on commit fa40a11.
Direct link to PR: #60827

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 27, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#60827!
1f2aca2 
Tested on commit rust-lang/rust@fa40a11.
Direct link to PR: <rust-lang/rust#60827>

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
@bors bors mentioned this pull request May 27, 2019
Merged
@oli-obk oli-obk deleted the late_symbol branch March 16, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @nnethercote @bors @Centril @rust-highfive @jonas-schievink