Skip to content

Parse lifetimes that start with a number and give specific error #58876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2019
Merged

Parse lifetimes that start with a number and give specific error #58876

merged 2 commits into from
Mar 13, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Mar 2, 2019

Fix #58786.

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2019
bjorn3
bjorn3 reviewed Mar 2, 2019
View reviewed changes
@estebank
Copy link
Contributor Author

estebank commented Mar 4, 2019

r? @petrochenkov

petrochenkov
petrochenkov reviewed Mar 8, 2019
View reviewed changes
petrochenkov
petrochenkov reviewed Mar 8, 2019
View reviewed changes
@petrochenkov
Copy link
Contributor

r=me with comments addressed

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2019
@estebank estebank force-pushed the numeric-lifetime branch 2 times, most recently from c7b3433 to cd61eda Compare March 8, 2019 21:29
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the numeric-lifetime branch 2 times, most recently from 63e071d to 61596bb Compare March 9, 2019 01:55
@estebank
Copy link
Contributor Author

estebank commented Mar 9, 2019

@bors r=petrochenkov rollup

@bors
Copy link
Collaborator

bors commented Mar 9, 2019

📌 Commit 61596bbd4744b43d390ec2bd0ea1afe8f26dccaf has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2019
petrochenkov
petrochenkov reviewed Mar 9, 2019
View reviewed changes
@petrochenkov
Copy link
Contributor

@bors r-

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 9, 2019
@estebank
Copy link
Contributor Author

estebank commented Mar 9, 2019

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Mar 9, 2019

📌 Commit f690821 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
@Centril
Rollup merge of rust-lang#58876 - estebank:numeric-lifetime, r=petroc…
2eeca49 
…henkov

Parse lifetimes that start with a number and give specific error

Fix rust-lang#58786.
@Centril Centril mentioned this pull request Mar 10, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
@Centril
Rollup merge of rust-lang#58876 - estebank:numeric-lifetime, r=petroc…
7cade09 
…henkov

Parse lifetimes that start with a number and give specific error

Fix rust-lang#58786.
@Centril Centril mentioned this pull request Mar 10, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
@Centril
Rollup merge of rust-lang#58876 - estebank:numeric-lifetime, r=petroc…
789aca0 
…henkov

Parse lifetimes that start with a number and give specific error

Fix rust-lang#58786.
@Centril Centril mentioned this pull request Mar 10, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
@Centril
Rollup merge of rust-lang#58876 - estebank:numeric-lifetime, r=petroc…
ea20f8a 
…henkov

Parse lifetimes that start with a number and give specific error

Fix rust-lang#58786.
@Centril Centril mentioned this pull request Mar 10, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 11, 2019
@Centril
Rollup merge of rust-lang#58876 - estebank:numeric-lifetime, r=petroc…
cfa209d 
…henkov

Parse lifetimes that start with a number and give specific error

Fix rust-lang#58786.
@Centril Centril mentioned this pull request Mar 11, 2019
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 11, 2019
@kennytm
Rollup merge of rust-lang#58876 - estebank:numeric-lifetime, r=petroc…
00a9ce1 
…henkov

Parse lifetimes that start with a number and give specific error

Fix rust-lang#58786.
@kennytm kennytm mentioned this pull request Mar 11, 2019
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 12, 2019
@pietroalbini
Rollup merge of rust-lang#58876 - estebank:numeric-lifetime, r=petroc…
4bcc150 
…henkov

Parse lifetimes that start with a number and give specific error

Fix rust-lang#58786.
@pietroalbini pietroalbini mentioned this pull request Mar 12, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 13, 2019
@Centril
Rollup merge of rust-lang#58876 - estebank:numeric-lifetime, r=petroc…
ad7b650 
…henkov

Parse lifetimes that start with a number and give specific error

Fix rust-lang#58786.
@Centril Centril mentioned this pull request Mar 13, 2019
Merged
bors added a commit that referenced this pull request Mar 13, 2019
@bors
Auto merge of #59151 - Centril:rollup, r=Centril
aa97448 
Rollup of 16 pull requests

Successful merges:

 - #58829 (librustc_interface: Update scoped-tls to 1.0)
 - #58876 (Parse lifetimes that start with a number and give specific error)
 - #58908 (Update rand version)
 - #58998 (Fix documentation of from_ne_bytes and from_le_bytes)
 - #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std)
 - #59057 (Standardize `Range*` documentation)
 - #59080 (Fix incorrect links in librustc_codegen_llvm documentation)
 - #59083 (Fix #54822 and associated faulty tests)
 - #59093 (Remove precompute_in_scope_traits_hashes)
 - #59101 (Reduces Code Repetitions like `!n >> amt`)
 - #59121 (impl FromIterator for Result: Use assert_eq! instead of assert!)
 - #59124 (Replace assert with assert_eq)
 - #59129 (Visit impl Trait for dead_code lint)
 - #59130 (Note that NonNull does not launder shared references for mutation)
 - #59132 (ignore higher-ranked object bound conditions created by WF)
 - #59138 (Simplify Iterator::{min, max})

Failed merges:

r? @ghost
@bors bors merged commit f690821 into rust-lang:master Mar 13, 2019
@matklad matklad mentioned this pull request Apr 29, 2019
Merged
5 tasks
@estebank estebank deleted the numeric-lifetime branch November 9, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@bjorn3 bjorn3 bjorn3 left review comments

+1 more reviewer

@VirrageS VirrageS VirrageS left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@estebank @rust-highfive @petrochenkov @bors @VirrageS @bjorn3 @michaelwoerister