-
Notifications
You must be signed in to change notification settings - Fork 13.8k
rustdoc-search: move animated throbber to bottom of results list #146385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Complaints about it being distracting, and causing people to wait until all of the results are loaded instead of using the incremental results as they come in, make me think this is a bad idea.
Some changes occurred in HTML/CSS/JS. |
rustbot has assigned @GuillaumeGomez. Use |
I disagree: how do I know there is nothing more to load? |
Lol, that's so funny. That's exactly what I started to do subconsciously looking back >.< As a middle ground, we could maybe hide the throbbers for the inactive/unselected tabs (only making them (re)appear once you select the relevant tab)? Unsure if that'll help in any way. |
The number isn't shown until it's done. |
And that made me think it was a bug. ^^' |
So thinking about it some more (although I REALLY love this loading animation), maybe what is missing is instead a marker to notify that the search is complete. |
random idea: move the throbber to the end of the results, so it's only visible if the user has scrolled past all of the results that have already been loaded. |
Could work too I guess. |
Here's a version using @lolbinarycat's idea. |
Can you host it somewhere please? |
Doesn't render as nicely but if that makes people happy... |
I'm confused. What's not as nice about it? |
Not sure exactly. Just "feel" less good but I honestly can't word what's bugging me... |
Preview: https://notriddle.com/rustdoc-html-demo-12/throbber/std/index.html
Complaints about it being distracting, and causing people to wait until all of the results are loaded instead of using the incremental results as they come in, make me think it was a bad idea to put it in the tab.
Part of #146048