Skip to content

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Sep 9, 2025

Preview: https://notriddle.com/rustdoc-html-demo-12/throbber/std/index.html

Complaints about it being distracting, and causing people to wait until all of the results are loaded instead of using the incremental results as they come in, make me think it was a bad idea to put it in the tab.

Part of #146048

Complaints about it being distracting, and causing people to wait
until all of the results are loaded instead of using the incremental
results as they come in, make me think this is a bad idea.
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@GuillaumeGomez
Copy link
Member

I disagree: how do I know there is nothing more to load?

@fmease
Copy link
Member

fmease commented Sep 10, 2025

causing people to wait until all of the results are loaded instead of using the incremental results as they come in

Lol, that's so funny. That's exactly what I started to do subconsciously looking back >.< As a middle ground, we could maybe hide the throbbers for the inactive/unselected tabs (only making them (re)appear once you select the relevant tab)? Unsure if that'll help in any way.

@notriddle
Copy link
Contributor Author

I disagree: how do I know there is nothing more to load?

The number isn't shown until it's done.

@GuillaumeGomez
Copy link
Member

I disagree: how do I know there is nothing more to load?

The number isn't shown until it's done.

And that made me think it was a bug. ^^'

@GuillaumeGomez
Copy link
Member

So thinking about it some more (although I REALLY love this loading animation), maybe what is missing is instead a marker to notify that the search is complete.

@lolbinarycat
Copy link
Contributor

random idea: move the throbber to the end of the results, so it's only visible if the user has scrolled past all of the results that have already been loaded.

@GuillaumeGomez
Copy link
Member

Could work too I guess.

@rustbot rustbot added the A-rustdoc-search Area: Rustdoc's search feature label Sep 10, 2025
@notriddle
Copy link
Contributor Author

Here's a version using @lolbinarycat's idea.

@GuillaumeGomez
Copy link
Member

Can you host it somewhere please?

@notriddle notriddle changed the title rustdoc-search: remove animated throbber rustdoc-search: move animated throbber to bottom of results list Sep 10, 2025
@notriddle
Copy link
Contributor Author

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Sep 10, 2025

Doesn't render as nicely but if that makes people happy...

@notriddle
Copy link
Contributor Author

I'm confused. What's not as nice about it?

@GuillaumeGomez
Copy link
Member

Not sure exactly. Just "feel" less good but I honestly can't word what's bugging me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants