Skip to content

Fold unnecessary visit_struct_field_def in AstValidator #142586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Fold unnecessary visit_struct_field_def in AstValidator #142586

merged 1 commit into from
Jun 17, 2025

Conversation

compiler-errors
Copy link
Member

We don't need it anymore since we removed the _: struct { } syntax experiment.

@rustbot
Copy link
Collaborator

rustbot commented Jun 16, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 16, 2025
@fmease
Copy link
Member

fmease commented Jun 16, 2025

r? fmease @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 16, 2025

📌 Commit 8a7b50a has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 17, 2025
@jhpratt
Rollup merge of rust-lang#142586 - compiler-errors:remove-visit-struc…
ccd9b6a 
…t-field-def, r=fmease

Fold unnecessary `visit_struct_field_def` in AstValidator

We don't need it anymore since we removed the `_: struct { }` syntax experiment.
@jhpratt jhpratt mentioned this pull request Jun 17, 2025
Closed
bors added a commit that referenced this pull request Jun 17, 2025
@bors
Auto merge of #142604 - jhpratt:rollup-77fsgte, r=jhpratt
896d9e4 
Rollup of 11 pull requests

Successful merges:

 - #140809 (Reduce special casing for the panic runtime)
 - #141608 (Add support for repetition to `proc_macro::quote`)
 - #141864 (Handle win32 separator for cygwin paths)
 - #142216 (Miscellaneous RefCell cleanups)
 - #142517 (Windows: Use anonymous pipes in Command)
 - #142570 (Reject union default field values)
 - #142584 (Handle same-crate macro for borrowck semicolon suggestion)
 - #142585 (Update books)
 - #142586 (Fold unnecessary `visit_struct_field_def` in AstValidator)
 - #142595 (Revert overeager warning for misuse of `--print native-static-libs`)
 - #142598 (Set elf e_flags on ppc64 targets according to abi)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Jun 17, 2025
Merged
rust-bors bot added a commit that referenced this pull request Jun 17, 2025
@rust-bors
Auto merge of #142613 - workingjubilee:rollup-yuod2hg, r=<try>
69b2373 
Rollup of 13 pull requests

Successful merges:

 - #138538 (Make performance description of String::{insert,insert_str,remove} more precise)
 - #141946 (std: refactor explanation of `NonNull`)
 - #142216 (Miscellaneous RefCell cleanups)
 - #142542 (Manually invalidate caches in SimplifyCfg.)
 - #142563 (Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism)
 - #142570 (Reject union default field values)
 - #142584 (Handle same-crate macro for borrowck semicolon suggestion)
 - #142585 (Update books)
 - #142586 (Fold unnecessary `visit_struct_field_def` in AstValidator)
 - #142587 (Make sure to propagate result from `visit_expr_fields`)
 - #142595 (Revert overeager warning for misuse of `--print native-static-libs`)
 - #142598 (Set elf e_flags on ppc64 targets according to abi)
 - #142601 (Add a comment to `FORMAT_VERSION`.)

r? `@ghost`
`@rustbot` modify labels: rollup
<!-- homu-ignore:start -->
[Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=138538,141946,142216,142542,142563,142570,142584,142585,142586,142587,142595,142598,142601)
<!-- homu-ignore:end -->
try-job: dist-apple-various
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 17, 2025
@workingjubilee
Rollup merge of rust-lang#142586 - compiler-errors:remove-visit-struc…
ba05d71 
…t-field-def, r=fmease

Fold unnecessary `visit_struct_field_def` in AstValidator

We don't need it anymore since we removed the `_: struct { }` syntax experiment.
@workingjubilee workingjubilee mentioned this pull request Jun 17, 2025
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 17, 2025
@workingjubilee
Rollup merge of rust-lang#142586 - compiler-errors:remove-visit-struc…
7b64b6b 
…t-field-def, r=fmease

Fold unnecessary `visit_struct_field_def` in AstValidator

We don't need it anymore since we removed the `_: struct { }` syntax experiment.
@workingjubilee workingjubilee mentioned this pull request Jun 17, 2025
Closed
bors added a commit that referenced this pull request Jun 17, 2025
@bors
Auto merge of #142616 - workingjubilee:rollup-0t8naf1, r=workingjubilee
2531756 
Rollup of 7 pull requests

Successful merges:

 - #141061 (Change __rust_no_alloc_shim_is_unstable to be a function)
 - #142585 (Update books)
 - #142586 (Fold unnecessary `visit_struct_field_def` in AstValidator)
 - #142587 (Make sure to propagate result from `visit_expr_fields`)
 - #142595 (Revert overeager warning for misuse of `--print native-static-libs`)
 - #142598 (Set elf e_flags on ppc64 targets according to abi)
 - #142601 (Add a comment to `FORMAT_VERSION`.)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-bors bot added a commit that referenced this pull request Jun 17, 2025
@rust-bors
Auto merge of #142616 - workingjubilee:rollup-0t8naf1, r=<try>
5367df5 
Rollup of 7 pull requests

Successful merges:

 - #141061 (Change __rust_no_alloc_shim_is_unstable to be a function)
 - #142585 (Update books)
 - #142586 (Fold unnecessary `visit_struct_field_def` in AstValidator)
 - #142587 (Make sure to propagate result from `visit_expr_fields`)
 - #142595 (Revert overeager warning for misuse of `--print native-static-libs`)
 - #142598 (Set elf e_flags on ppc64 targets according to abi)
 - #142601 (Add a comment to `FORMAT_VERSION`.)

r? `@ghost`
`@rustbot` modify labels: rollup
<!-- homu-ignore:start -->
[Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=141061,142585,142586,142587,142595,142598,142601)
<!-- homu-ignore:end -->
try-job: x86_64-gnu-aux
bors added a commit that referenced this pull request Jun 17, 2025
@bors
Auto merge of #142613 - workingjubilee:rollup-yuod2hg, r=workingjubilee
f3db639 
Rollup of 13 pull requests

Successful merges:

 - #138538 (Make performance description of String::{insert,insert_str,remove} more precise)
 - #141946 (std: refactor explanation of `NonNull`)
 - #142216 (Miscellaneous RefCell cleanups)
 - #142542 (Manually invalidate caches in SimplifyCfg.)
 - #142563 (Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism)
 - #142570 (Reject union default field values)
 - #142584 (Handle same-crate macro for borrowck semicolon suggestion)
 - #142585 (Update books)
 - #142586 (Fold unnecessary `visit_struct_field_def` in AstValidator)
 - #142587 (Make sure to propagate result from `visit_expr_fields`)
 - #142595 (Revert overeager warning for misuse of `--print native-static-libs`)
 - #142598 (Set elf e_flags on ppc64 targets according to abi)
 - #142601 (Add a comment to `FORMAT_VERSION`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3018154 into rust-lang:master Jun 17, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 17, 2025
rust-timer added a commit that referenced this pull request Jun 17, 2025
@rust-timer
Unrolled build for #142586
410e4dc 
Rollup merge of #142586 - compiler-errors:remove-visit-struct-field-def, r=fmease

Fold unnecessary `visit_struct_field_def` in AstValidator

We don't need it anymore since we removed the `_: struct { }` syntax experiment.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 18, 2025
@bors
Auto merge of #142613 - workingjubilee:rollup-yuod2hg, r=workingjubilee
ba32451 
Rollup of 13 pull requests

Successful merges:

 - rust-lang/rust#138538 (Make performance description of String::{insert,insert_str,remove} more precise)
 - rust-lang/rust#141946 (std: refactor explanation of `NonNull`)
 - rust-lang/rust#142216 (Miscellaneous RefCell cleanups)
 - rust-lang/rust#142542 (Manually invalidate caches in SimplifyCfg.)
 - rust-lang/rust#142563 (Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism)
 - rust-lang/rust#142570 (Reject union default field values)
 - rust-lang/rust#142584 (Handle same-crate macro for borrowck semicolon suggestion)
 - rust-lang/rust#142585 (Update books)
 - rust-lang/rust#142586 (Fold unnecessary `visit_struct_field_def` in AstValidator)
 - rust-lang/rust#142587 (Make sure to propagate result from `visit_expr_fields`)
 - rust-lang/rust#142595 (Revert overeager warning for misuse of `--print native-static-libs`)
 - rust-lang/rust#142598 (Set elf e_flags on ppc64 targets according to abi)
 - rust-lang/rust#142601 (Add a comment to `FORMAT_VERSION`.)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Jun 24, 2025
@bors
Auto merge of rust-lang#142613 - workingjubilee:rollup-yuod2hg, r=wor…
a46ec5c 
…kingjubilee

Rollup of 13 pull requests

Successful merges:

 - rust-lang#138538 (Make performance description of String::{insert,insert_str,remove} more precise)
 - rust-lang#141946 (std: refactor explanation of `NonNull`)
 - rust-lang#142216 (Miscellaneous RefCell cleanups)
 - rust-lang#142542 (Manually invalidate caches in SimplifyCfg.)
 - rust-lang#142563 (Refine run-make test ignores due to unpredictable `i686-pc-windows-gnu` unwind mechanism)
 - rust-lang#142570 (Reject union default field values)
 - rust-lang#142584 (Handle same-crate macro for borrowck semicolon suggestion)
 - rust-lang#142585 (Update books)
 - rust-lang#142586 (Fold unnecessary `visit_struct_field_def` in AstValidator)
 - rust-lang#142587 (Make sure to propagate result from `visit_expr_fields`)
 - rust-lang#142595 (Revert overeager warning for misuse of `--print native-static-libs`)
 - rust-lang#142598 (Set elf e_flags on ppc64 targets according to abi)
 - rust-lang#142601 (Add a comment to `FORMAT_VERSION`.)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @fmease @bors @petrochenkov