-
Notifications
You must be signed in to change notification settings - Fork 13.8k
refactor: replace &PathBuf with &Path to enhance generality #134420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Some changes occurred in src/tools/compiletest cc @jieyouxu Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
8dd38ff
to
01bd99b
Compare
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in src/tools/compiletest cc @jieyouxu This PR modifies If appropriate, please update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks for the contribution, but please revert changes to subtrees like rustfmt.
01bd99b
to
7eb0d84
Compare
@compiler-errors Done :) |
Generally I want to discourage using the rust-analyzer style guide to make basically non-functional changes to rust-lang/rust, but since this is already done I'll approve it. @bors r+ rollup |
Uh oh!
There was an error while loading. Please reload this page.