[DO NOT MERGE] bootstrap with `-Znext-solver=globally` #133502

lcnr · 2024-11-26T15:26:47Z

A revival of #124812.

Tracking:

Tracking Issue for -Znext-solver #107374

Current status:

~~./x.py b --stage 2 passes 🎉~~

try builds succeed 🎉 🎉 🎉

first perf run 👻 second perf run 👻

crater

This does not detect hangs or memory issues.

date	#crates	#regressions
2025.04.11	100	2
2025.04.11	1000	27
2025.04.17	10000	456
2025.04.18	10000	437
2025.04.24	10000	164
2025.04.26	10000	108
2025.04.28	10000	91
2025.05.01	10000	145 woops
2025.05.03	624228¹	1585
2025.05.05	8964²	931
2025.05.06	4401²	726
2025.05.07	2704²	668
2025.05.09	2345²	664
2025.09.20	701952¹	4739 + 7039 spurious

in-flight changes

r? @ghost

a complete crater run ↩ ↩²
only testing crates which may have regressed from the above run ↩ ↩² ↩³ ↩⁴

compiler-errors · 2024-11-27T04:03:51Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status, we're failing in: - failing in `rustc_next_trait_solver` with 126 instances of the following error ``` error[E0311]: the parameter type `I` may not live long enough | help: consider adding an explicit lifetime bound --> compiler/rustc_next_trait_solver/src/solve/trait_goals.rs:624:53 | 624 ~ fn consider_structural_builtin_unsize_candidates<'a>( 625 ~ ecx: &mut EvalCtxt<'a, D>, 626 | goal: Goal<I, Self>, 627 ~ ) -> Vec<Candidate<I>> where I: 'a { ``` - `itertools` hangs, we're already encountered this hang in our previous attempt due to large type sizes. I believe that it's simply caused by a missing cache somewhere, potentially in `wf.rs`, but other visitors may also be responsible. See rust-itertools/itertools#945 for more details ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now r? `@ghost`

bors · 2024-11-27T04:05:03Z

⌛ Trying commit f631ca8 with merge ca04381...

compiler-errors · 2024-11-27T04:05:17Z

I also pushed:

I think this is sufficient to make the compiler build, or at least ./x.py build --stage=2 completes successfully on my local branch.

bors · 2024-11-27T06:15:40Z

💔 Test failed - checks-actions

bors · 2024-11-27T10:43:04Z

☔ The latest upstream changes (presumably #133527) made this pull request unmergeable. Please resolve the merge conflicts.

lqd · 2024-11-27T11:42:49Z

Next failure is on color-print-proc-macro-0.3.6 while building cargo.

pub fn repro() -> impl FnMut() {
    if true {
        || ()
    } else {
        || ()
    }
}

godbolt

compiler-errors · 2024-11-27T17:49:50Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: `./x.py b --stage 2` passes 🎉 ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now - rust-lang#133517 * rust-lang#133518 * rust-lang#133519 * rust-lang#133520 * rust-lang#133521 * rust-lang#133524 r? `@ghost`

bors · 2024-11-27T17:51:02Z

⌛ Trying commit 6210ed3 with merge ac5ccad...

bors · 2024-11-27T20:03:42Z

💔 Test failed - checks-actions

compiler-errors · 2024-11-27T20:15:22Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: `./x.py b --stage 2` passes 🎉 ### commits - rust-lang#133501 - rust-lang#133493 - 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR - c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now - rust-lang#133517 * rust-lang#133518 * rust-lang#133519 * rust-lang#133520 * rust-lang#133521 * rust-lang#133524 r? `@ghost`

bors · 2024-11-27T20:16:33Z

⌛ Trying commit 8fa8f40 with merge 550ae0d...

lqd · 2024-11-27T20:26:10Z

I was reducing the new failure but you've already fixed it ^^

lcnr · 2025-09-18T15:02:18Z

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally`

rust-bors · 2025-09-18T17:16:13Z

☀️ Try build successful (CI)
Build commit: 2ac7ec3 (2ac7ec3900900b4061ea9d1b8efc18e8ba5030e9, parent: 32e3d9f59bae4bcf436bc1e28723c696d2c75b11)

lcnr · 2025-09-18T17:28:51Z

dropped #146720 for now as that one has a subtle issue

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally`

lcnr · 2025-09-18T17:29:40Z

@bors cancel

@bors try

[DO NOT MERGE] bootstrap with `-Znext-solver=globally`

rust-bors · 2025-09-18T19:43:51Z

☀️ Try build successful (CI)
Build commit: 9139c04 (9139c04dbcb9b2d486133e14b03362e4337eb12b, parent: 4cd91ef8223ef54111d21aa9e9e71b3b26477dd3)

lcnr · 2025-09-18T21:43:16Z

@rust-timer build 9139c04

@craterbot check

craterbot · 2025-09-18T21:43:32Z

👌 Experiment pr-133502-14 created and queued.
🤖 Automatically detected try build 9139c04
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-09-18T21:44:11Z

🚧 Experiment pr-133502-14 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

rust-timer · 2025-09-18T22:42:38Z

Finished benchmarking commit (9139c04): comparison URL.

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

stm32f4-0.15.1
image-0.25.6
regression-31157
eza-0.21.2
unify-linearly
unicode-normalization-0.1.24
serde-1.0.219
issue-46449
clap_derive-4.5.32
regex-automata-0.4.8
ucd
cargo-0.87.1
syn-2.0.101
ripgrep-14.1.1
cranelift-codegen-0.119.0
issue-88862
derive
many-assoc-items
libc-0.2.172
issue-58319
projection-caching
nalgebra-0.33.0
hyper-1.6.0
wg-grammar
bitmaps-3.2.1
html5ever-0.31.0
diesel-2.2.10
serde-1.0.219-threads4
match-stress
typenum-1.18.0
serde_derive-1.0.219

❗ ❗ ❗ ❗ ❗

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	15.2%	[0.2%, 144.1%]	160
Regressions ❌ (secondary)	136.7%	[0.2%, 4192.2%]	153
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-13.0%, -0.1%]	40
All ❌✅ (primary)	15.2%	[0.2%, 144.1%]	160

Max RSS (memory usage)

Results (primary 6.2%, secondary 117.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	6.4%	[0.9%, 37.8%]	101
Regressions ❌ (secondary)	160.9%	[1.2%, 1715.7%]	41
Improvements ✅ (primary)	-6.2%	[-7.5%, -5.0%]	2
Improvements ✅ (secondary)	-2.3%	[-5.2%, -0.9%]	15
All ❌✅ (primary)	6.2%	[-7.5%, 37.8%]	103

Cycles

Results (primary 15.3%, secondary 238.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	15.3%	[1.5%, 112.3%]	118
Regressions ❌ (secondary)	250.5%	[2.0%, 5802.6%]	100
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.7%	[-11.5%, -2.0%]	5
All ❌✅ (primary)	15.3%	[1.5%, 112.3%]	118

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.718s -> 501.403s (5.84%)
Artifact size: 389.93 MiB -> 386.35 MiB (-0.92%)

lcnr · 2025-09-19T07:40:37Z

woops, rustdoc is broken xd

craterbot · 2025-09-20T13:53:44Z

🎉 Experiment pr-133502-14 is completed!
📊 4739 regressed and 8 fixed (701952 total)
📊 7039 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-133502-14/retry-regressed-list.txt ↩

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 26, 2024

This comment has been minimized.

Sign in to view

compiler-errors force-pushed the rust4 branch from c3ef9cd to f631ca8 Compare November 27, 2024 04:03

This comment was marked as off-topic.

Sign in to view

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2024

compiler-errors force-pushed the rust4 branch from f631ca8 to 6210ed3 Compare November 27, 2024 17:49

This comment has been minimized.

Sign in to view

compiler-errors force-pushed the rust4 branch from 6210ed3 to 8fa8f40 Compare November 27, 2024 20:15

This comment has been minimized.

Sign in to view

lcnr force-pushed the rust4 branch from 3808f83 to b32819b Compare September 18, 2025 14:57

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 18, 2025

Auto merge of #133502 - lcnr:rust4, r=<try>

2ac7ec3

[DO NOT MERGE] bootstrap with `-Znext-solver=globally`

This comment has been minimized.

Sign in to view

lcnr force-pushed the rust4 branch from b32819b to aae1efe Compare September 18, 2025 17:28

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 18, 2025

Auto merge of #133502 - lcnr:rust4, r=<try>

7aeab7a

[DO NOT MERGE] bootstrap with `-Znext-solver=globally`

compiler-errors and others added 4 commits September 18, 2025 19:29

instantiate predicate binder without recanonicalizing goal in new solver

fb55f95

i hate this :<

21c8d35

enable -Znext-solver by default

386ad1c

w

22389a5

lcnr force-pushed the rust4 branch from aae1efe to 22389a5 Compare September 18, 2025 17:29

rust-bors bot added a commit that referenced this pull request Sep 18, 2025

Auto merge of #133502 - lcnr:rust4, r=<try>

9139c04

[DO NOT MERGE] bootstrap with `-Znext-solver=globally`

This comment has been minimized.

Sign in to view

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Sep 18, 2025

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 20, 2025

[DO NOT MERGE] bootstrap with -Znext-solver=globally #133502

Are you sure you want to change the base?

[DO NOT MERGE] bootstrap with -Znext-solver=globally #133502

Uh oh!

Conversation

lcnr commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

crater

in-flight changes

Footnotes

Uh oh!

This comment has been minimized.

compiler-errors commented Nov 27, 2024

Uh oh!

bors commented Nov 27, 2024

Uh oh!

compiler-errors commented Nov 27, 2024

Uh oh!

This comment was marked as off-topic.

This comment has been minimized.

bors commented Nov 27, 2024

Uh oh!

bors commented Nov 27, 2024

Uh oh!

lqd commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Nov 27, 2024

Uh oh!

bors commented Nov 27, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Nov 27, 2024

Uh oh!

compiler-errors commented Nov 27, 2024

Uh oh!

bors commented Nov 27, 2024

Uh oh!

lqd commented Nov 27, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

lcnr commented Sep 18, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Sep 18, 2025

Uh oh!

lcnr commented Sep 18, 2025

Uh oh!

This comment has been minimized.

lcnr commented Sep 18, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Sep 18, 2025

Uh oh!

lcnr commented Sep 18, 2025

Uh oh!

This comment has been minimized.

craterbot commented Sep 18, 2025

Uh oh!

craterbot commented Sep 18, 2025

Uh oh!

rust-timer commented Sep 18, 2025

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

lcnr commented Sep 19, 2025

Uh oh!

craterbot commented Sep 20, 2025

Footnotes

Uh oh!

Uh oh!

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` #133502

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` #133502

lcnr commented Nov 26, 2024 •

edited

Loading

lqd commented Nov 27, 2024 •

edited

Loading