Rollup of 4 pull requests #130992
Closed
Rollup of 4 pull requests #130992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation comments for `catch_unwind` and `thread::join` to indicate new behavioral guarantee when catching a foreign exception.
… r=Mark-Simulacrum Update `catch_unwind` doc comments for `c_unwind` Updates `catch_unwind` doc comments to indicate that catching a foreign exception _will no longer_ be UB. Instead, there are two possible behaviors, though it is not specified which one an implementation will choose. Nominated for t-lang to confirm that they are okay with making such a promise based on t-opsem FCP, or whether they would like to be included in the FCP. Related: rust-lang#74990, rust-lang#115285, rust-lang/reference#1226
…ark-Simulacrum resolve rust-lang#130122: reword 'sort-by' edge-conditions documentation See rust-lang#130122 for rationale & preliminary discussion.
…=Mark-Simulacrum Clarifications for set_nonblocking methods Closes rust-lang#129903. The issue mentions that `send`, `recv` and other operations are interpreted by some users as methods of `TcpSocket` which led to confusion since it hasn't them. To fix it I added "system" into the documentation as being more precise for two reasons: * it's makes it clear that these names are system operations; * it doesn't point to the location of these methods like `libc` because not every system is POSIX compatible.
…otriddle Update `browser-ui-test` version and make use of `wait-for*-false` commands I added `wait-for*-false` commands, making possible these changes. r? `@notriddle`
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=4 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#128321 (Update `catch_unwind` doc comments for `c_unwind`) - rust-lang#130416 (resolve rust-lang#130122: reword 'sort-by' edge-conditions documentation) - rust-lang#130743 (Clarifications for set_nonblocking methods) - rust-lang#130983 (Update `browser-ui-test` version and make use of `wait-for*-false` commands) r? `@ghost` `@rustbot` modify labels: rollup
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
catch_unwinddoc comments forc_unwind#128321 (Updatecatch_unwinddoc comments forc_unwind)sort_by(and related methods) is potentially self-contradictory #130122: reword 'sort-by' edge-conditions documentation)browser-ui-testversion and make use ofwait-for*-falsecommands #130983 (Updatebrowser-ui-testversion and make use ofwait-for*-falsecommands)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup